Changes between Initial Version and Version 1 of Ticket #2492, comment 1
- Timestamp:
- 2020-07-08T12:22:07+02:00 (4 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #2492, comment 1
initial v1 1 the mpp part of the icebergs is quite mysterious to me... but:2 - In icbini, it is clearly said that it is not working when using 1 processus.3 {{{#!fortran4 IF( lk_mpp .AND. jpni == 1 ) CALL ctl_stop( 'icbinit: having ONE processor in x currently does not work' )5 }}}6 So I have little hope it can work without key_mpp_mpi... [[BR]]7 BTW how can we justify in 2020 that we keep (and maintain) the possibility to use NEMO without this key? We are no more in fix format as we don't use punched card any more... Same story for key_mpp_mpi. Who has a computer with only one core today? In addition, we need it for xios and 1D configurations can still use 1 core even with MPI...8 - The duplication of the mpp routines with extended halos (_ext) only for the icebergs was originally not the best idea. Duplications is a quick (and dirty) solution that is hard to maintain as the code changes. This solution is now obsolete (and is not really compatible) since we introduced nn_hls > 1 [[BR]]9 10 => to me, the mpi part of the icebergs should be entirely reviewed and rewritten using the default mpp routines.
