Changes between Version 1 and Version 2 of 2019WP/ENHANCE-04_AndrewC-reporting/Internal_Namelists

Timestamp:

2019-10-01T15:37:41+02:00 (5 years ago)

Author:

acc

Comment:

--

2019WP/ENHANCE-04_AndrewC-reporting/Internal_Namelists

@@ -117 +117 @@
   END SUBROUTINE load_nml
 }}}
+
+'''Full development branch'''
+
+This approach has been implemented and tested on a 2019 development branch:
+
+https://forge.ipsl.jussieu.fr/nemo/browser/NEMO/branches/2019/dev_r11613_ENHANCE-04_namelists_as_internalfiles
+
+This branch contains only the substantive changes; to compile and run tests all REWIND and CLOSE operations on the (no longer) units have to be removed. These changes affect many more files but can be scripted so are not included the branch in order to make a later merge easier. The scripts used to prepare code for testing are included below. With these additional changes this code passes most SETTE tests but the AGRIF preprocessor does not currently accept the new allocatable character strings. The conversion routine first bails on:
+
+{{{
+fcm_internal compile:F nemo /home/acc/NEMO/IMMERSE/dev_r11613_ENHANCE-04_namelists_as_internalfiles/tests/VORTEX_ST/NEMOFILES/ppsrc/nemo/in_out_manager.f90 in_out_manager.f90
+/home/acc/NEMO/IMMERSE/dev_r11613_ENHANCE-04_namelists_as_internalfiles/mk/agrifpp.sh  in_out_manager.f90 /home/acc/NEMO/IMMERSE/dev_r11613_ENHANCE-04_namelists_as_internalfiles/tests/VORTEX_ST/NEMOFILES/inc  /home/acc/NEMO/IMMERSE/dev_r11613_ENHANCE-04_namelists_as_internalfiles/tests/VORTEX_ST/NEMOFILES/ppsrc/nemo/in_out_manager.f90
+syntax error line 135, file in_out_manager.f90 motclef = |:|
+fcm_internal compile failed (256)
+
+which is the line:
+
+   CHARACTER(LEN=:), ALLOCATABLE :: numnam_ref      !: character buffer for reference namelist
+
+}}}
+
+AGRIF will need to be made to understand the (LEN=: ) syntax before this solution can be progressed.
+
+All non-AGRIF SETTE tests are passing but note none of the current tests use multiple BDY namelists; a solution for that issue has yet to be coded.
+
+
+'''Lists and scripts'''
+To minimise changes that need to be merged later, only the substantive changes have been checked into the development branch. These changes include the new routine in lib_mpp.F90, buffer declarations and replacement of any ctl_opn calls for namelist input. The list of files in this category is held in src/substantive.list and is:
+
+{{{
+ICE/icestp.F90 
+OCE/IOM/in_out_manager.F90 
+OCE/LBC/lib_mpp.F90 
+OCE/nemogcm.F90 
+OFF/nemogcm.F90 
+SAO/nemogcm.F90 
+SAS/nemogcm.F90 
+TOP/PISCES/SED/sedini.F90 
+TOP/PISCES/sms_pisces.F90 
+TOP/PISCES/trcnam_pisces.F90 
+TOP/trc.F90 
+TOP/trcnam.F90
+}}}
+
+A list of files potentially containing REWIND and CLOSE statements (but excluding files in the substantive list) can be built by running the following script in the src directory:
+
+{{{
+#!/bin/bash
+#
+INUNITS=( numnam_ref numnam_cfg numnat_ref numnat_cfg numtrc_ref numtrc_cfg numnam_ice_ref numnam_ice_cfg numnamsed_ref numnamsed_cfg numnatp_cfg numnatp_ref )
+RM_CMDS=( REWIND  CLOSE  )
+#
+# First build a list of files likely to need alteration
+#
+ if [ -f all_rewfiles.list ] ; then rm all_rewfiles.list; fi
+ for n in `seq 0 1 $(( ${#INUNITS[*]} - 1 ))`
+  do
+   grep -l -i ${INUNITS[$n]} `find ./ -name '*.[Ffh]90'` >> all_rewfiles.list
+   grep -l -i ${INUNITS[$n]} `find ../tests -name '*.[Ffh]90'` | grep -v WORK | grep -v BLD | grep -v NEMOFILES >> all_rewfiles.list
+   grep -l -i ${INUNITS[$n]} `find ../cfgs -name '*.[Ffh]90'`  | grep -v WORK | grep -v BLD | grep -v NEMOFILES >> all_rewfiles.list
+ done
+ sort -u all_rewfiles.list > alluniq_rewfiles.list
+ for f in `cat substantive.list`
+ do
+  ff=`echo $f | sed -e 's:/:\\\/:g'`
+  echo $ff
+  ed - alluniq_rewfiles.list << EOF
+/$ff/d
+w
+q
+EOF
+ done
+}}}
+
+and this list can be used to target an editing script which removes any REWIND or CLOSE statements on converted units (also to be run in src):
+
+{{{
+#!/bin/bash
+#
+INUNITS=( numnam_ref numnam_cfg numnat_ref numnat_cfg numtrc_ref numtrc_cfg numnam_ice_ref numnam_ice_cfg numnamsed_ref numnamsed_cfg numnatp_cfg numnatp_ref )
+RM_CMDS=( REWIND  CLOSE  )
+#
+for f in `cat alluniq_rewfiles.list`
+do
+ n=0
+ for n in `seq 0 1 $(( ${#INUNITS[*]} - 1 ))`
+ do
+  for m in `seq 0 1 $(( ${#RM_CMDS[*]} - 1 ))`
+  do
+   perl -ni.bak -e 'print unless m@.*\s*'${RM_CMDS[$m]}'\s*\(\s*'${INUNITS[$n]}'\s*\).*@i'  $f
+  done
+ done
+done
+cd ../
+rm `find ./ -name '*.bak'`   
+}}}
+
+.