New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
2020WP/ENHANCE-04_dford_OBSOP_BGC (diff) – NEMO

Changes between Version 3 and Version 4 of 2020WP/ENHANCE-04_dford_OBSOP_BGC


Ignore:
Timestamp:
2020-11-11T16:53:05+01:00 (3 years ago)
Author:
dford
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • 2020WP/ENHANCE-04_dford_OBSOP_BGC

    v3 v4  
    1515||=Digest       || Adapt OBS code to make it easier to add new (especially biogeochemical) variables in a generic fashion || 
    1616||=Dependencies || None                                                  || 
    17 ||=Branch       || source:/NEMO/branches/{YEAR}/dev_r{REV}_{ACTION_NAME} || 
    18 ||=Previewer(s) || Names                                                 || 
    19 ||=Reviewer(s)  || Names                                                 || 
    20 ||=Ticket       || #XXXX                                                 || 
     17||=Branch       || source:/NEMO/branches/2020/dev_r13747_ENHANCE-04_dford_OBSOP_BGC || 
     18||=Previewer(s) || Dan Lea                                               || 
     19||=Reviewer(s)  || Dan Lea                                               || 
     20||=Ticket       || #2567                                                 || 
    2121 
    2222=== Description 
    2323 
    24 Adapt observation operator code so that variables are handled as generically as possible in the code, making it easier to add new variables, both surface and profile, with as little hardwired as possible. This will be particularly useful for adding new biogeochemical variables from different models. 
     24Adapt observation operator code so that variables are handled more generically as possible in the code, making it easier to add new variables. This will be particularly useful for adding new biogeochemical profile variables from different models. 
    2525 
    2626=== Implementation 
     
    3333}}} 
    3434 
    35 ''...'' 
     35Change some of the internal handling of profile observation variables. Currently it's only set up to be able to handle inputs with two variables in, either temperature and salinity, or U&V velocity. This change will remove those restrictions, so that users adding an observation operator for third party biogeochemical model variables will be able to more easily. The changes also add some error checking on the variable names read in from observation files, as currently these aren't checked. 
     36 
     37This will require edits to the following modules in OCE/OBS: 
     38* diaobs.F90 
     39* obs_oper.F90 
     40* obs_prep.F90 
     41* obs_read_prof.F90 
     42* obs_read_surf.F90 
     43* obs_write.F90 
     44 
     45The following new variables will be added to the &namobs namelist: 
     46* ln_default_fp_indegs 
     47* rn_default_avglamscl 
     48* rn_default_avgphiscl 
     49* nn_2dint_default [renamed from nn_2dint] 
    3650 
    3751=== Documentation updates 
     
    5064}}} 
    5165 
    52 ''...'' 
     66These are changes which have already been incorporated and used in the branch source:/branches/UKMO/dev_r5518_obs_oper_update. See r9306 and r11546, noting that the changes specific to third party biogeochemical models will not be included here. 
    5367 
    5468== Tests