Changes between Version 14 and Version 15 of 2020WP/KERNEL-06_techene_better_e3_management

Timestamp:

2020-08-21T12:53:42+02:00 (4 years ago)

Author:

techene

Comment:

--

2020WP/KERNEL-06_techene_better_e3_management

@@ -42 +42 @@
 '''KERNEL-06's version 1 implementation : /NEMO/branches/2020/dev_r12377_KERNEL-06_techene_e3''' 
 
+==== starting point
+
 In NEMO r12377 scale factors (e3*) at u-v-w-uw-vw-f-points are interpolated from e3t at Kbb, Kmm, and Kaa.
 The module in charge of scale factor management is src/OCE/DOM/domvvl.F90. 
@@ -82 +84 @@
 }}}
 
-In version 1 we implement changes progressively and validate step by step regarding GYRE_PISCES test case. For backward compatibility we introduce a cpp key key_qco in order to isolate new scale factor implementation from former vvl version. qco stand for for "quasi eulerian coordinate". 
+==== developpments 
+
+In version 1 of source://dev_r12377_KERNEL-06_techene_e3 we implement changes progressively and validate step by step regarding GYRE_PISCES test case. We remove all the vvl routines usage thus we replace e3t/u/v/w/uw/vw at 3 time step + e3f (19) 3d tables storage and twice e3u/v "after" + e3u/v "now" + e3f/w/uw/vw "now" + e3w/uw/vw "before" (13) 3d tables interpolation at each step and e3u/v/f/w/uw/vw "now" + e3u/v/w/uw/vw "before" (11) 3d tables interpolation at initialisation or restart by r3t/u/v at 3 time steps and r3f i.e. (10) 2d table storage and on the fly light computation. For backward compatibility we introduce a cpp key key_qco in order to isolate new scale factor implementation from former vvl version. qco stand for for "quasi eulerian coordinate". 
 - new variables added in dom_oce and domain 
 {{{
-r3. with . = [t,u,v,f] are 2d in space ssh/hP0
+r3P with P = [t,u,v,f] are 2d in space ssh/hP0
 }}}
 - new module in DOM : dom_qco
@@ -94 +98 @@
    --> dom_qco_r3c[Kbb] at t-u-v  -points
 }}}
-- new substitute in DOM : domzgr_substitute
-When key_qco is active e3. is no longer a variable but an expression. 
-Each time e3. appears in a routine an include domzgr_substitute in the module enables to replace it by a (e3._0 ( 1 + r3. ) * mask.) like expression. 
+- new substitute in DOM : domzgr_substitute When key_qco is active e3. is no longer a variable but an expression. Each time e3. appears in a routine an include domzgr_substitute in the module enables to replace it by a (e3._0 ( 1 + r3. ) * mask.) like expression. 
 {{{
 #   define  e3t(i,j,k,t)   (e3t_0(i,j,k)*(1._wp+r3t(i,j,t)*tmask(i,j,k)))
@@ -122 +124 @@
 
 Important points : 
-- e3. expression involves tables of distinct dimension then e3.(:,:,:) call fails it may be necessary to introduce temporary variables (same for water height expression)
+- e3. expression involves tables of distinct dimension then e3.(:,:,: ) call fails it may be necessary to introduce temporary variables (same for water height expression)
 - "e3. =" is no longer possible
 - e3t/u/v/f modifications did not introduce any difference in the results, e3w modification does because both approaches vvl and qco do not take into account of the bottom level in the same way
 - in GYRE e3w_0 are not the half sum of e3u_0 so the way it is implemented in the reference version is not convinient
 - e3. substitution makes lines longer than 136 character this may be a problem for compilers (most have been checked but not all)
-- ssh filtering has been displaced upper in order to provide filtered r3. in TOP asselin filtering 
-- when key_qco is not active we pass SETTE and this version has been delivered for mid-merge party ! 
--- Some silly allocating memory bugs found and a not that silly bug in the implicit mode for SPITZ12 configuration.
+- ssh filtering has been displaced upper in order to provide filtered r3P in TOP asselin filtering 
+- when key_qco is not active we pass SETTE and this version r13167 has been delivered for mid-merge party ! Some silly allocating memory bugs found and a not that silly bug in implicit mode triggering for SPITZ12 configuration (Dt instead of 2Dt required).
+
+
+
+'''KERNEL-06's version 2 implementation : /NEMO/branches/2020/dev_r13327_KERNEL-06_techene_e3_v2'''
+
+
+
+
+
+
+
 
 
@@ -149 +161 @@
 RUN SETTE and deliver version for mid-merge party ! Some silly allocating memory bugs found and a not that silly bug in the implicit mode for SPITZ12 configuration. 
 [Etape 8, 9 & 11]
-
-
-'''KERNEL-06's version 2 implementation : /NEMO/branches/2020/dev_r13327_KERNEL-06_techene_e3_v2''' 
+