| 1 | = Name and subject of the action |
| 2 | |
| 3 | Last edition: '''[[Wikinfo(changed_ts)]]''' by '''[[Wikinfo(changed_by)]]''' |
| 4 | |
| 5 | The PI is responsible to closely follow the progress of the action, |
| 6 | and especially to contact NEMO project manager if |
| 7 | the delay on preview (or review) are longer than the 2 weeks expected. |
| 8 | |
| 9 | [[PageOutline(2, , inline)]] |
| 10 | |
| 11 | == Summary |
| 12 | |
| 13 | ||=Action || rearangemnt of the pressure gradient according to A19 from NEMO book 4.0.1 || |
| 14 | ||=PI(S) || Sibylle & Gurvan || |
| 15 | ||=Digest || In accordance with NEMO documentation, using using the density anomaly in dynhpg routines avoid computing a surface presure gradient that is removed afterwards || |
| 16 | ||=Dependencies || If any || |
| 17 | ||=Branch || source:/NEMO/branches/2020/dev_r13333_techene_gm_HPG_SPG || |
| 18 | ||=Previewer(s) || Names || |
| 19 | ||=Reviewer(s) || Names || |
| 20 | ||=Ticket || #XXXX || |
| 21 | |
| 22 | === Description |
| 23 | |
| 24 | {{{#!box width=25em help |
| 25 | Describe the goal of development and the methodology, \\ |
| 26 | add reference documents or publications if relevant. |
| 27 | }}} |
| 28 | Current implementation of the pressure gradient... blablabla... |
| 29 | We modify the implementation of the pressure gradient according to A19 from NEMO book 4.0.1 : |
| 30 | in dynhpg routines we compute the specific pressure gradient with the density anomaly : when possible we merely remove the znad, otherwise we remove explicitely the surface pressure gradient (dynhpg_prj, dynhpg_djc). |
| 31 | in dynspg routines we compute the surface pressure gradient with constant density systematically |
| 32 | |
| 33 | Note that using a density anomaly only in dynhpg_isf, requires also changes in isfload and isfstp. |
| 34 | |
| 35 | ''...'' |
| 36 | |
| 37 | === Implementation |
| 38 | |
| 39 | {{{#!box width=35em help |
| 40 | Describe flow chart of the changes in the code. \\ |
| 41 | List the Fortran modules and subroutines to be created/edited/deleted. \\ |
| 42 | Detailed list of new variables to be defined (including namelists), \\ |
| 43 | give for each the chosen name and description wrt coding rules. |
| 44 | }}} |
| 45 | |
| 46 | ''...'' |
| 47 | |
| 48 | Index: src/OCE/DYN/dynspg_exp.F90 |
| 49 | compute the surface pressure gradient with constant density systematically |
| 50 | |
| 51 | Index: src/OCE/oce.F90 |
| 52 | Index: src/OCE/DYN/dynspg.F90 |
| 53 | Index: src/OCE/DYN/dynspg_ts.F90 |
| 54 | formatting and some optimisation |
| 55 | |
| 56 | Index: src/OCE/DYN/dynhpg.F90 |
| 57 | we compute the specific pressure gradient with the density anomaly |
| 58 | dynhpg_zco |
| 59 | dynhpg_zps |
| 60 | dynhpg_sco |
| 61 | dynhpg_djc |
| 62 | dynhpg_prj |
| 63 | dynhpg_isf |
| 64 | |
| 65 | |
| 66 | Index: src/OCE/ISF/isf_oce.F90 |
| 67 | Index: src/OCE/ISF/isfload.F90 |
| 68 | Index: src/OCE/ISF/isfstp.F90 |
| 69 | |
| 70 | |
| 71 | |
| 72 | === Documentation updates |
| 73 | |
| 74 | {{{#!box width=55em help |
| 75 | Using previous parts, define the main changes to be done in the NEMO literature |
| 76 | (manuals, guide, web pages, …). |
| 77 | }}} |
| 78 | |
| 79 | ''...'' |
| 80 | |
| 81 | == Preview |
| 82 | |
| 83 | {{{#!box width=50em info |
| 84 | [[Include(wiki:Developers/DevProcess#preview_)]] |
| 85 | }}} |
| 86 | |
| 87 | ''...'' |
| 88 | |
| 89 | == Tests |
| 90 | |
| 91 | {{{#!box width=50em info |
| 92 | [[Include(wiki:Developers/DevProcess#tests)]] |
| 93 | }}} |
| 94 | |
| 95 | ''...'' |
| 96 | GYRE_PISCES for zco, sco, prj |
| 97 | ISOMIP for isf |
| 98 | |
| 99 | Because we change the arrangement of adding and subtractig the "surface pressure gradient" we do not expect to have the same results as before. |
| 100 | |
| 101 | == Review |
| 102 | |
| 103 | {{{#!box width=50em info |
| 104 | [[Include(wiki:Developers/DevProcess#review)]] |
| 105 | }}} |
| 106 | |
| 107 | ''...'' |