Changes between Version 13 and Version 14 of Developers/DevProcess

Timestamp:

2016-02-22T15:06:33+01:00 (8 years ago)

Author:

nicolasmartin

Comment:

--

Developers/DevProcess

@@ -45 +45 @@
 ----
 == Section 3: Review to be completed by the reviewer(s) ==
-Once the development is done, the PI should complete the tests section below and ask the reviewers to start their review, and add the date in the table above. A sucessful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).
+Once the development is done, the PI should complete the tests section below and ask the reviewers to start their review, and add the date in the table above. A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).
 
 === Test section (to be completed be PI) ===
-|| Question || Discussion || Answer ||
-|| Can this change be shown to produce expected impact? (if option activated)? || || ||
-|| Can this change be shown to have a null impact? (if option not activated) || || ||
-|| Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || || ||
-|| Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || || ||
-|| Results of the required bit comparability tests been run: Are there no differences when activating the development? || || ||
-|| If some differences appear, is reason for the change valid/understood? || || ||
-|| If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || || ||
-|| Is this change expected to preserve all diagnostics? || || ||
-|| If no, is reason for the change valid/understood? || || ||
-|| Are there significant changes in run time/memory? || || ||
+{{{
+#!TracForm
+|| Questions || Answer || Comment ||
+|| Can this change be shown to produce expected impact? (if option activated)? || [tf.radio:3.1 true] Yes [tf.radio:3.1 false] No || [tf.textarea:3.1 'Write here' 20 5] ||
+|| Can this change be shown to have a null impact? (if option not activated) || [tf.radio:3.2 true] Yes [tf.radio:3.2 false] No || [tf.textarea:3.2 'Write here' 20 5] ||
+|| Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || [tf.radio:3.3 true] Yes [tf.radio:3.3 false] No || [tf.textarea:3.3 'Write here' 20 5] ||
+|| Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || [tf.radio:3.4 true] Yes [tf.radio:3.4 false] No || [tf.textarea:3.4 'Write here' 20 5] ||
+|| Results of the required bit comparability tests been run: Are there no differences when activating the development? || [tf.radio:3.5 true] Yes [tf.radio:3.5 false] No || [tf.textarea:3.5 'Write here' 20 5] ||
+|| If some differences appear, is reason for the change valid/understood? || [tf.radio:3.6 true] Yes [tf.radio:3.6 false] No || [tf.textarea:3.6 'Write here' 20 5] ||
+|| If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || [tf.radio:3.7 true] Yes [tf.radio:3.7 false] No || [tf.textarea:3.7 'Write here' 20 5] ||
+|| Is this change expected to preserve all diagnostics? || [tf.radio:3.8 true] Yes [tf.radio:3.8 false] No || [tf.textarea:3.8 'Write here' 20 5] ||
+|| If no, is reason for the change valid/understood? || [tf.radio:3.9 true] Yes [tf.radio:3.9 false] No || [tf.textarea:3.9 'Write here' 20 5] ||
+|| Are there significant changes in run time/memory? || [tf.radio:3.10 true] Yes [tf.radio:3.10 false] No || [tf.textarea:3.10 'Write here' 20 5] ||
 
 === Code changes and documentation ===
-|| Question || Discussion || Answer ||
-|| Is the proposed methodology now implemented? || || ||
-|| Are the code changes in agreement with the flowchart defined at Preview step? || || YES/NO ||
-|| Are the code changes in agrement with list of routines and variables as proposed at Preview step?[[BR]]If, not, are the discrepencies acceptable? || || YES/NO ||
-|| Is the in-line documentation accurate and sufficient? || || YES/NO ||
-|| Do the code changes comply with NEMO coding standards? || || YES/NO ||
-|| Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || || YES/NO ||
-|| Are the reference manual tex files now updated following the proposed summary in preview section? || || YES/NO ||
-|| Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?[[BR]]If yes, please describe and ask PI. A yes answer must include all documentation available. || || YES/NO ||
+|| Question || Answer || Comment ||
+|| Is the proposed methodology now implemented? || [tf.radio:3.11 true] Yes [tf.radio:3.11 false] No || [tf.textarea:3.11 'Write here' 20 5] ||
+|| Are the code changes in agreement with the flowchart defined at Preview step? || [tf.radio:3.12 true] Yes [tf.radio:3.12 false] No || [tf.textarea:3.12 'Write here' 20 5] ||
+|| Are the code changes in agreement with list of routines and variables as proposed at Preview step?[[BR]]If, not, are the discrepancies acceptable? || [tf.radio:3.13 true] Yes [tf.radio:3.13 false] No || [tf.textarea:3.13 'Write here' 20 5] ||
+|| Is the in-line documentation accurate and sufficient? || [tf.radio:3.14 true] Yes [tf.radio:3.14 false] No || [tf.textarea:3.14 'Write here' 20 5] ||
+|| Do the code changes comply with NEMO coding standards? || [tf.radio:3.15 true] Yes [tf.radio:3.15 false] No || [tf.textarea:3.15 'Write here' 20 5] ||
+|| Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || [tf.radio:3.16 true] Yes [tf.radio:3.16 false] No || [tf.textarea:3.16 'Write here' 20 5] ||
+|| Are the reference manual tex files now updated following the proposed summary in preview section? || [tf.radio:3.17 true] Yes [tf.radio:3.17 false] No || [tf.textarea:3.17 'Write here' 20 5] ||
+|| Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?[[BR]]If yes, please describe and ask PI. A yes answer must include all documentation available. || [tf.radio:3.18 true] Yes [tf.radio:3.18 false] No || [tf.textarea:3.18 'Write here' 20 5] ||
 
 === Review Summary ===
- * '''Is the review fully sucessful?'''
+ * '''Is the review fully successful?'''
  * '''If not, please indicate date and what is still missing?'''
+}}}
 
-Once review is sucessful, the of end of review should be added in table at top of the page, and the development must be scheduled for merge during next Merge Party Meeting.
+Once review is successful, the of end of review should be added in table at top of the page, and the development must be scheduled for merge during next Merge Party Meeting.