Changes between Version 31 and Version 32 of Developers/DevProcess

Timestamp:

2016-02-24T12:05:29+01:00 (8 years ago)

Author:

nicolasmartin

Comment:

--

Developers/DevProcess

@@ -24 +24 @@
 [tf.textarea:description 'Describe the goal of development, and the methodology.\n\nAdd reference documents or publications if relevant.' 200 20]
 === Part 2: Implementation ===
-[tf.textarea:implementation 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules), and description' 200 20]
+[tf.textarea:implementation 'Describe flow chart of the changes in the code.\n\nList the .F90 files and modules to be changed.\n\nDetailed list of new variables (including namelists) to be defined.\nGive for each the chosen name (following coding rules) and definition.' 200 20]
 === Part 3: Reference manual updates ===
 [tf.textarea:manual 'Using part 1 and 2, define the summary of changes to be done in the NEMO reference manual (tex files).' 200 20]
 }}}
-
 '''Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks.'''
 
@@ -40 +39 @@
 #!submit_label 'Submit Preview'
 || Questions || Answer || Comment ||
-|| Does the previewer agree with the proposed methodology? || [tf.select:2.1 '' Yes No NR] || [tf.textarea:2.1 'Write here' 50 10] ||
-|| Does the previewer agree with the proposed flowchart and list of routines to be changed? || [tf.select:2.2 '' Yes No NR] || [tf.textarea:2.2 'Write here' 50 10] ||
-|| Does the previewer agree with the proposed new list of variables, including agreement with coding rules? || [tf.select:2.3 '' Yes No NR] || [tf.textarea:2.3 'Write here' 50 10] ||
-|| Does the previewer agree with the proposed summary of updates in reference manual? || [tf.select:2.4 '' Yes No NR] || [tf.textarea:2.4 'Write here' 50 10] ||
-|| ... ... ... || [tf.select:2.X '' Yes No NR] || [tf.textarea:2.X 'Write here' 50 10] ||
+|| Does the previewer agree with the proposed methodology? || [tf.select:2.1 '' Yes No NR] || [tf.textarea:2.1 'Add a comment?' 50 10] ||
+|| Does the previewer agree with the proposed flowchart and list of routines to be changed? || [tf.select:2.2 '' Yes No NR] || [tf.textarea:2.2 'Add a comment?' 50 10] ||
+|| Does the previewer agree with the proposed new list of variables, including agreement with coding rules? || [tf.select:2.3 '' Yes No NR] || [tf.textarea:2.3 'Add a comment?' 50 10] ||
+|| Does the previewer agree with the proposed summary of updates in reference manual? || [tf.select:2.4 '' Yes No NR] || [tf.textarea:2.4 'Add a comment?' 50 10] ||
+|| ... ... ... || [tf.select:2.X '' Yes No NR] || [tf.textarea:2.X 'Add a comment?' 50 10] ||
 }}}
 [[BR]]'''Once all "YES" have been reached, the PI can start the development into his development branch.'''
@@ -57 +56 @@
 #!submit_label 'Submit Tests'
 || Questions || Answer || Comment ||
-|| Can this change be shown to produce expected impact? (if option activated)? || [tf.select:3.1 '' Yes No NR] || [tf.textarea:3.1 'Write here' 50 10] ||
-|| Can this change be shown to have a null impact? (if option not activated) || [tf.select:3.2 '' Yes No NR] || [tf.textarea:3.2 'Write here' 50 10] ||
-|| Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || [tf.select:3.3 '' Yes No NR] || [tf.textarea:3.3 'Write here' 50 10] ||
-|| Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || [tf.select:3.4 '' Yes No NR] || [tf.textarea:3.4 'Write here' 50 10] ||
-|| Results of the required bit comparability tests been run: Are there no differences when activating the development? || [tf.select:3.5 '' Yes No NR] || [tf.textarea:3.5 'Write here' 50 10] ||
-|| If some differences appear, is reason for the change valid/understood? || [tf.select:3.6 '' Yes No NR] || [tf.textarea:3.6 'Write here' 50 10] ||
-|| If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || [tf.select:3.7 '' Yes No NR] || [tf.textarea:3.7 'Write here' 50 10] ||
-|| Is this change expected to preserve all diagnostics? || [tf.select:3.8 '' Yes No NR] || [tf.textarea:3.8 'Write here' 50 10] ||
-|| If no, is reason for the change valid/understood? || [tf.select:3.9 '' Yes No NR] || [tf.textarea:3.9 'Write here' 50 10] ||
-|| Are there significant changes in run time/memory? || [tf.select:3.10 '' Yes No NR] || [tf.textarea:3.10 'Write here' 50 10] ||
-|| ... ... ... || [tf.select:3.XX '' Yes No NR] || [tf.textarea:3.XX 'Write here' 50 10] ||
+|| Can this change be shown to produce expected impact? (if option activated)? || [tf.select:3.1 '' Yes No NR] || [tf.textarea:3.1 'Add a comment?' 50 10] ||
+|| Can this change be shown to have a null impact? (if option not activated) || [tf.select:3.2 '' Yes No NR] || [tf.textarea:3.2 'Add a comment?' 50 10] ||
+|| Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || [tf.select:3.3 '' Yes No NR] || [tf.textarea:3.3 'Add a comment?' 50 10] ||
+|| Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || [tf.select:3.4 '' Yes No NR] || [tf.textarea:3.4 'Add a comment?' 50 10] ||
+|| Results of the required bit comparability tests been run: Are there no differences when activating the development? || [tf.select:3.5 '' Yes No NR] || [tf.textarea:3.5 'Add a comment?' 50 10] ||
+|| If some differences appear, is reason for the change valid/understood? || [tf.select:3.6 '' Yes No NR] || [tf.textarea:3.6 'Add a comment?' 50 10] ||
+|| If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || [tf.select:3.7 '' Yes No NR] || [tf.textarea:3.7 'Add a comment?' 50 10] ||
+|| Is this change expected to preserve all diagnostics? || [tf.select:3.8 '' Yes No NR] || [tf.textarea:3.8 'Add a comment?' 50 10] ||
+|| If no, is reason for the change valid/understood? || [tf.select:3.9 '' Yes No NR] || [tf.textarea:3.9 'Add a comment?' 50 10] ||
+|| Are there significant changes in run time/memory? || [tf.select:3.10 '' Yes No NR] || [tf.textarea:3.10 'Add a comment?' 50 10] ||
+|| ... ... ... || [tf.select:3.XX '' Yes No NR] || [tf.textarea:3.XX 'Add a comment?' 50 10] ||
 }}}
-
 ----
 == Review ==
@@ -80 +78 @@
 === Code changes and documentation ===
 || Question || Answer || Comment ||
-|| Is the proposed methodology now implemented? || [tf.select:3.11 '' Yes No NR] || [tf.textarea:3.11 'Write here' 50 10] ||
-|| Are the code changes in agreement with the flowchart defined at Preview step? || [tf.select:3.12 '' Yes No NR] || [tf.textarea:3.12 'Write here' 50 10] ||
-|| Are the code changes in agreement with list of routines and variables as proposed at Preview step?[[BR]]If not, are the discrepancies acceptable? || [tf.select:3.13 '' Yes No NR] || [tf.textarea:3.13 'Write here' 50 10] ||
-|| Is the in-line documentation accurate and sufficient? || [tf.select:3.14 '' Yes No NR] || [tf.textarea:3.14 'Write here' 50 10] ||
-|| Do the code changes comply with NEMO coding standards? || [tf.select:3.15 '' Yes No NR] || [tf.textarea:3.15 'Write here' 50 10] ||
-|| Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || [tf.select:3.16 '' Yes No NR] || [tf.textarea:3.16 'Write here' 50 10] ||
-|| Are the reference manual tex files now updated following the proposed summary in preview section? || [tf.select:3.17 '' Yes No NR] || [tf.textarea:3.17 'Write here' 50 10] ||
-|| Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?[[BR]]If yes, please describe and ask PI. A yes answer must include all documentation available. || [tf.select:3.18 '' Yes No NR] || [tf.textarea:3.18 'Write here' 50 10] ||
-|| ... ... ... || [tf.select:3.XXX '' Yes No NR] || [tf.textarea:3.XXX 'Write here' 50 10] ||
+|| Is the proposed methodology now implemented? || [tf.select:3.11 '' Yes No NR] || [tf.textarea:3.11 'Add a comment?' 50 10] ||
+|| Are the code changes in agreement with the flowchart defined at Preview step? || [tf.select:3.12 '' Yes No NR] || [tf.textarea:3.12 'Add a comment?' 50 10] ||
+|| Are the code changes in agreement with list of routines and variables as proposed at Preview step?[[BR]]If not, are the discrepancies acceptable? || [tf.select:3.13 '' Yes No NR] || [tf.textarea:3.13 'Add a comment?' 50 10] ||
+|| Is the in-line documentation accurate and sufficient? || [tf.select:3.14 '' Yes No NR] || [tf.textarea:3.14 'Add a comment?' 50 10] ||
+|| Do the code changes comply with NEMO coding standards? || [tf.select:3.15 '' Yes No NR] || [tf.textarea:3.15 'Add a comment?' 50 10] ||
+|| Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || [tf.select:3.16 '' Yes No NR] || [tf.textarea:3.16 'Add a comment?' 50 10] ||
+|| Are the reference manual tex files now updated following the proposed summary in preview section? || [tf.select:3.17 '' Yes No NR] || [tf.textarea:3.17 'Add a comment?' 50 10] ||
+|| Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?[[BR]]If yes, please describe and ask PI. A yes answer must include all documentation available. || [tf.select:3.18 '' Yes No NR] || [tf.textarea:3.18 'Add a comment?' 50 10] ||
+|| ... ... ... || [tf.select:3.XXX '' Yes No NR] || [tf.textarea:3.XXX 'Add a comment?' 50 10] ||
 === Review Summary ===
 '''Is the review fully successful?'''[tf.select:status '' Yes No][[BR]]
 [tf.textarea:status 'If not, please indicate what is still missing.' 50 10]
 }}}
-
 Once review is successful, the development must be scheduled for merge during next Merge Party Meeting.