Changes between Version 5 and Version 6 of Developers/DevProcess
- Timestamp:
- 2016-02-02T06:54:23+01:00 (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Developers/DevProcess
v5 v6 32 32 ---- 33 33 == Section 2: Preview to be completed by the previewer(s) == 34 Since the preview step must be completed before the PI starts the coding, the previewer(s) 34 Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent the request to the previewer(s), see start and end dates of preview above.[[BR]]'''For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions.''' 35 35 36 36 || Questions || Discussion || Answer [[BR]]("YES" or "NO") || 37 37 || '''Does the previewer agree with the proposed methodology?''' || || || 38 || '''Does the previewer agree with the proposed flowchart ?''' || || ||38 || '''Does the previewer agree with the proposed flowchart and list of routines to be changed?''' || || || 39 39 || '''Does the previewer agree with the proposed new list of variables, including agreement with coding rules?''' || || || 40 40 || '''Does the previewer agree with the proposed summary of updates in reference manual?''' || || || … … 44 44 ---- 45 45 == Section 3: Review to be completed by the reviewer(s) == 46 Once the development is done, the PI should ask the reviewers to start their review, and add the date in the table above. A sucessful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November)/ 47 46 48 === Ticket Details, Documentation and Code changes === 47 || Do you understand the area of code being altered and the reasoning why it is being altered? || YES/NO || 48 || Do the proposed code changes correspond with the stated reason for the change? || YES/NO || 49 || Is the in-line documentation accurate and sufficient? || YES/NO || 50 || Do the code changes comply with NEMO coding standards? || YES/NO || 51 || Is the Ticket documented with sufficient detail for others to understand the impact of the change? || YES/NO || 52 || Does any corresponding external documentation require updating? || YES/NO || 53 || If yes, which docs and have the updates been drafted? || YES/NO || 54 || Are namelist changes required for this change? || YES/NO || 55 || If yes, have they been done? || YES/NO || 56 || Has a completed Ticket Summary template been appended to the ticket to aid code reviews || YES/NO || 57 || Does this summary correspond with your understanding of the full ticket? || YES/NO || 49 || Question || Discussion || Answer || 50 || Is the proposed methodology now implemented? || || || 51 || Are the code changes in agreement with the flowchart defined at Preview step? || || YES/NO || 52 || Are the code changes in agrement with list of routines and variables as proposed at Preview step?[[BR]]If, not, are the discrepencies acceptable? || || YES/NO || 53 || Is the in-line documentation accurate and sufficient? || || YES/NO || 54 || Do the code changes comply with NEMO coding standards? || || YES/NO || 55 || Is the Ticket documented with sufficient detail for others to understand the impact of the change? || || YES/NO || 56 || Are the reference manual tex files now updated following the proposed summary in preview section? || || YES/NO || 57 || IS there a need for some documentation on the web pages? || || YES/NO || 58 || Are namelist changes required for this change? || || YES/NO || 59 || If yes, have they been done? || || YES/NO || 60 || Has a completed Ticket Summary template been appended to the ticket to aid code reviews || || YES/NO || 61 || Does this summary correspond with your understanding of the full ticket? || || YES/NO || 58 62 59 63 Ticket, Documentation and Code comments
