Changes between Version 87 and Version 88 of Developers/DevProcess
- Timestamp:
- 2018-11-06T17:06:37+01:00 (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Developers/DevProcess
v87 v88 6 6 7 7 == Summary 8 9 The following sections should be completed by the PI of the development, before starting to develop the code, in order to find agreement on the method and the implementation beforehand. 8 10 9 11 ||=Action || ''{ACTION_NAME} Subject'' || … … 16 18 ||=Wiki || wiki:{YEAR}WP/{ACTION_NAME} || 17 19 18 The following sections should be completed by the PI of the development, before starting to develop the code, in order to find agreement on the method and the implementation beforehand.19 20 20 === Description 21 21 … … 25 25 === Implementation 26 26 27 Describe flow chart of the changes in the code \\28 List the Fortran modules and subroutines to be created/edited/deleted \\29 Detailed list of new variables to be defined (including namelists), give for each the chosen name wrt coding rules and description.27 Describe flow chart of the changes in the code. \\ 28 List the Fortran modules and subroutines to be created/edited/deleted. \\ 29 Detailed list of new variables to be defined (including namelists), give for each the chosen name and description wrt coding rules. 30 30 31 31 === Documentation updates … … 33 33 Using previous parts, define the main changes to be done in the NEMO literature (manuals, guide, web pages, ...). 34 34 35 Once the PI has completed this section, he should send a mail to the previewer(s), asking them to preview the work within two weeks. 35 ---- 36 37 Once the PI has completed this section, he should ask the previewer(s) to preview the work within two weeks. 36 38 37 39 == Preview #preview_ 38 40 39 Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent the request to the previewer(s). \\ 40 An iterative process should take place between PI and previewer(s) in order to find a consensus on 41 41 Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent the request to the previewer(s). 42 43 Then an iterative process should take place between PI and previewer(s) in order to find a consensus 44 45 __Possible bootlenecks__: 42 46 - the methodology 43 47 - the flowchart and list of routines to be changed … … 45 49 - the summary of updates in literature 46 50 51 ---- 52 47 53 Once an agreement has been reached, preview is ended and the PI can start the development into his branch. 48 54 49 55 == Tests #tests 50 56 51 Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) 52 Detailed results of restartability and reproducibility when the option is activated. \\Please indicate the configuration used for this test 57 Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review. 53 58 59 This part should contain the detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) and detailed results of restartability and reproducibility when the option is activated on specified configurations used for this test 60 61 __Regular checks__: 54 62 - Can this change be shown to produce expected impact (option activated)? 55 63 - Can this change be shown to have a null impact (option not activated)? … … 63 71 == Review #review 64 72 65 Once the development is done, the PI should complete the tests section below and ask the reviewers to start their review. \\66 73 A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November). 67 74 68 === Code changes and documentation 69 75 __Assessments__: 70 76 - Is the proposed methodology now implemented? 71 77 - Are the code changes in agreement with the flowchart defined at preview step? … … 76 82 - Is the project literature (manual, guide, web, ...) now updated or completed following the proposed summary in preview section? 77 83 78 === Finding 84 __Finding__: 79 85 80 * __Is the review fully successful?__ 81 * __If not, please indicate date and what is still missing?__ 86 Is the review fully successful? If not, please indicate what is still missing 87 88 ---- 82 89 83 90 Once review is successful, the development must be scheduled for merge during next Merge Party Meeting.
