| | 5 | ---- |
| | 6 | |
| | 7 | == Preview |
| | 8 | |
| | 9 | Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent the request to the previewer(s), see start and end dates of preview above. \\ |
| | 10 | '''For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions.''' |
| | 11 | |
| | 12 | ||= Questions ||= Discussion ||= Answer \\('YES'|'NO'|'NA') || |
| | 13 | || '''Does the previewer agree with the proposed methodology?''' || || || |
| | 14 | || '''Does the previewer agree with the proposed flowchart and list of routines to be changed?''' || || || |
| | 15 | || '''Does the previewer agree with the proposed new list of variables, including agreement with coding rules?''' || || || |
| | 16 | || '''Does the previewer agree with the proposed summary of updates in reference manual?''' || || || |
| | 17 | |
| | 18 | Once all "YES" have been reached, Ending date of preview should be added in table above, and the PI can start the development into his development branch. |
| | 19 | |
| | 20 | ---- |
| | 21 | |
| | 22 | == Review |
| | 23 | |
| | 24 | Once the development is done, the PI should complete the tests section below and ask the reviewers to start their review, and add the date in the table above. A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November). |
| | 25 | |
| | 26 | === Test |
| | 27 | |
| | 28 | ||= Question ||= Discussion ||= Answer || |
| | 29 | || Can this change be shown to produce expected impact? (if option activated)? || || || |
| | 30 | || Can this change be shown to have a null impact? (if option not activated) || || || |
| | 31 | || Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test || || || |
| | 32 | || Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration) || || || |
| | 33 | || Results of the required bit comparability tests been run: Are there no differences when activating the development? || || || |
| | 34 | || If some differences appear, is reason for the change valid/understood? || || || |
| | 35 | || If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations? || || || |
| | 36 | || Is this change expected to preserve all diagnostics? || || || |
| | 37 | || If no, is reason for the change valid/understood? || || || |
| | 38 | || Are there significant changes in run time/memory? || || || |
| | 39 | |
| | 40 | === Code changes and documentation |
| | 41 | |
| | 42 | ||= Question ||= Discussion ||= Answer || |
| | 43 | || Is the proposed methodology now implemented? || || || |
| | 44 | || Are the code changes in agreement with the flowchart defined at Preview step? || || || |
| | 45 | || Are the code changes in agreement with list of routines and variables as proposed at Preview step? \\If, not, are the discrepancies acceptable? || || || |
| | 46 | || Is the in-line documentation accurate and sufficient? || || || |
| | 47 | || Do the code changes comply with NEMO coding standards? || || || |
| | 48 | || Is the !ticket of development documented with sufficient details for others to understand the impact of the change? || || || |
| | 49 | || Are the reference manual tex files now updated following the proposed summary in preview section? || || || |
| | 50 | || Is there a need for some documentation on the web pages (in addition to in-line and reference manual)? \\If yes, please describe and ask PI. A yes answer must include all documentation available. || || || |
| | 51 | |
| | 52 | === Summary |
| | 53 | |
| | 54 | * '''Is the review fully successful?''' |
| | 55 | * '''If not, please indicate date and what is still missing?''' |
| | 56 | |
| | 57 | Once review is successful, the of end of review should be added in table at top of the page, and the development must be scheduled for merge during next Merge Party Meeting. |
