Changes between Version 5 and Version 6 of ticket/0681/Review

Timestamp:

2010-10-05T09:50:22+02:00 (14 years ago)

Author:

rblod

Comment:

--

ticket/0681/Review

@@ -30 +30 @@
 could be REAL(wp), DIMENSION(jpi,jpj), INTENT( OUT )::  psinu, pcosu, psinv, pcosv! copy of data
 
- * OPA_SRC/OBS : [[BR]] header is missing in new routines (see existing routine), sometimes there are reference to NEMOVAR licence[[BR]]
+ * OPA_SRC/OBS  and OPA_SRC/ASM: [[BR]] header is missing in new routines (see existing routine), sometimes there are reference to NEMOVAR licence[[BR]]
 
   !!----------------------------------------------------------------------[[BR]] !! NEMO/OPA 3.3 , LOCEAN-IPSL (2010)[[BR]] !! $Id$[[BR]] !! Software governed by the CeCILL licence (modipsl/doc/NEMO_CeCILL.txt)[[BR]]  !!----------------------------------------------------------------------[[BR]]
@@ -45 +45 @@
 IOIPSL library provides similar calendar functionalities in calendar module (I'm not sure for the optional kdate argument), we are using it in the rest of the code:
 
-USE IOIPSL[[BR]]  
-CALL  ymds2ju (year,month,day,sec,julian)[[BR]] 
-CALL  ju2ymds (julian,year,month,day,sec)[[BR]]
+USE IOIPSL[[BR]]   CALL  ymds2ju (year,month,day,sec,julian)[[BR]]  CALL  ju2ymds (julian,year,month,day,sec)[[BR]]
 
- * It may be logical to define kind of data fbsp and fbdp in par_kind.F90 rather than in obs_fbm[[BR]]
- * Using nf90_open rather than iom_open may be a sources a problem when using nesting (maybe one day) with key agrif (I should talk with Arthur and Eric), Idon't know if there is a reason to it, please use iom_open when possible[[BR]]
- * some routine in obs_mpp.F90 seems duplicated in lib_mpp.F90 (obs_mpp_max_integer,obs_mpp_sum_integers in OBS and mpp_max, mpp_sum in lib_mpp) and anyway those which are not specific to obs should be included in lib_mpp.F90[[BR]]
- * module mpp_map could be include in OPA_SRC/lib_mpp.F90 since it's not specific to OBS[[BR]]
+ * in OBS, It may be logical to define kind of data fbsp and fbdp in par_kind.F90 rather than in obs_fbm[[BR]]
+ * in OBS, Using nf90_open rather than iom_open may be a sources a problem when using nesting (maybe one day) with key agrif (I should talk with Arthur and Eric), Idon't know if there is a reason to it, please use iom_open when possible[[BR]]
+ * in OBS some routine in obs_mpp.F90 seems duplicated in lib_mpp.F90 (obs_mpp_max_integer,obs_mpp_sum_integers in OBS and mpp_max, mpp_sum in lib_mpp) and anyway those which are not specific to obs should be included in lib_mpp.F90[[BR]]
+ * in OBS module mpp_map could be include in OPA_SRC/lib_mpp.F90 since it's not specific to OBS[[BR]]
+ * in ASM, routine calc_month_len does the same thing than ioget_mon_len provided by IOIPSL
 
 '''3. MISC '''
 
-It would be nice to have access to an observation file (enact) or at least a reference to a link to one in the routine
+It would be nice to have access to an observation file (enact) or at least a reference to a link to one in the routine to use key_diaobs
 
 '''Ticket Details, Documentation and Code changes'''