Changes between Version 2 and Version 3 of ticket/0848/Review

Timestamp:

2011-10-03T14:25:13+02:00 (13 years ago)

Author:

sga

Comment:

--

ticket/0848/Review

@@ -42 +42 @@
 ||Do the code changes comply with NEMO coding standards?||Almost||
 ||Are code changes consistent with the design of NEMO?||Yes||
-||Is the code free of unwanted TABs?||YES/NO||
+||Is the code free of unwanted TABs?||unchecked||
 ||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO||
 ||If no, ensure collaboration agreement has been added to the ticket keywords||||
@@ -48 +48 @@
 Add specific code comments or suggested alterations here.
 
+Code differences between trunk revision 2803 and branch revision 2815:
+
+  NEMOGCM/NEMO/OPA_SRC/nemogcm.F90
+  NEMOGCM/NEMO/OPA_SRC/SBC/sbcice_lim_2.F90
+    childfreq is incremented inside a piece of code run only every nn_fsbc timesteps
+    Does nn_fsbc have to be 1 for this to work?
+
+  NEMOGCM/NEMO/OPA_SRC/BDY/bdy_oce.F90
+  NEMOGCM/NEMO/OPA_SRC/BDY/bdytides.F90
+  NEMOGCM/NEMO/OPA_SRC/OBS/obs_sla_types.F90
+  NEMOGCM/NEMO/OPA_SRC/OBS/obs_types.F90
+    unless I've done my comparisons incorrectly, it's not clear to me why BDY and OBS changes have been made
+
+  NEMOGCM/NEMO/OPA_SRC/par_oce.F90
+  NEMOGCM/NEMO/LIM_SRC_2/limhdf_2.F90
+    changes here would seem to be just to avoid work array clashes so would appear to belong in the trunk rather than here
+
+  NEMOGCM/NEMO/LIM_SRC_2/limtrp_2.F90
+  NEMOGCM/NEMO/LIM_SRC_2/limadv_2.F90
+    more work space changes
+
+  NEMOGCM/NEMO/LIM_SRC_2/limrhg_2.F90
+  NEMOGCM/NEMO/LIM_SRC_2/iceini_2.F90
+  NEMOGCM/NEMO/LIM_SRC_2/ice_2.F90
+  NEMOGCM/NEMO/LIM_SRC_3/limrhg.F90
+    calls agrif_dyn_lim with cd_type of 'U' or 'V', but this routine (in agrif_lim2_interp.F90) does most work only when cd_type is 'V'
+    is this correct?
+
+  NEMOGCM/NEMO/NST_SRC/agrif_user.F90
+  NEMOGCM/NEMO/NST_SRC/agrif_ice.F90
+  NEMOGCM/NEMO/NST_SRC/agrif_opa_update.F90
+  NEMOGCM/NEMO/NST_SRC/agrif2model.F90
+  NEMOGCM/NEMO/NST_SRC/agrif_lim2_interp.F90
+  NEMOGCM/NEMO/NST_SRC/agrif_lim2_update.F90
+  NEMOGCM/NEMO/NST_SRC/agrif_oce.F90
+
 === Review Summary ===
-Add summary here
+I believe that this code has already been used by several groups with NEMO v3.2.
+There is an argument therefore for acceptance in v3.3.1 with these groups retesting as appropriate, assuming that the extra agrif code 
+here is substantially unchanged from the extra code they were using.
 
 === Approval for the trunk ===