Changes between Version 2 and Version 3 of ticket/0848/Review


Ignore:
Timestamp:
2011-10-03T14:25:13+02:00 (9 years ago)
Author:
sga
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/0848/Review

    v2 v3  
    4242||Do the code changes comply with NEMO coding standards?||Almost|| 
    4343||Are code changes consistent with the design of NEMO?||Yes|| 
    44 ||Is the code free of unwanted TABs?||YES/NO|| 
     44||Is the code free of unwanted TABs?||unchecked|| 
    4545||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO|| 
    4646||If no, ensure collaboration agreement has been added to the ticket keywords|||| 
     
    4848Add specific code comments or suggested alterations here. 
    4949 
     50Code differences between trunk revision 2803 and branch revision 2815: 
     51 
     52  NEMOGCM/NEMO/OPA_SRC/nemogcm.F90 
     53  NEMOGCM/NEMO/OPA_SRC/SBC/sbcice_lim_2.F90 
     54    childfreq is incremented inside a piece of code run only every nn_fsbc timesteps 
     55    Does nn_fsbc have to be 1 for this to work? 
     56 
     57  NEMOGCM/NEMO/OPA_SRC/BDY/bdy_oce.F90 
     58  NEMOGCM/NEMO/OPA_SRC/BDY/bdytides.F90 
     59  NEMOGCM/NEMO/OPA_SRC/OBS/obs_sla_types.F90 
     60  NEMOGCM/NEMO/OPA_SRC/OBS/obs_types.F90 
     61    unless I've done my comparisons incorrectly, it's not clear to me why BDY and OBS changes have been made 
     62 
     63  NEMOGCM/NEMO/OPA_SRC/par_oce.F90 
     64  NEMOGCM/NEMO/LIM_SRC_2/limhdf_2.F90 
     65    changes here would seem to be just to avoid work array clashes so would appear to belong in the trunk rather than here 
     66 
     67  NEMOGCM/NEMO/LIM_SRC_2/limtrp_2.F90 
     68  NEMOGCM/NEMO/LIM_SRC_2/limadv_2.F90 
     69    more work space changes 
     70 
     71  NEMOGCM/NEMO/LIM_SRC_2/limrhg_2.F90 
     72  NEMOGCM/NEMO/LIM_SRC_2/iceini_2.F90 
     73  NEMOGCM/NEMO/LIM_SRC_2/ice_2.F90 
     74  NEMOGCM/NEMO/LIM_SRC_3/limrhg.F90 
     75    calls agrif_dyn_lim with cd_type of 'U' or 'V', but this routine (in agrif_lim2_interp.F90) does most work only when cd_type is 'V' 
     76    is this correct? 
     77 
     78  NEMOGCM/NEMO/NST_SRC/agrif_user.F90 
     79  NEMOGCM/NEMO/NST_SRC/agrif_ice.F90 
     80  NEMOGCM/NEMO/NST_SRC/agrif_opa_update.F90 
     81  NEMOGCM/NEMO/NST_SRC/agrif2model.F90 
     82  NEMOGCM/NEMO/NST_SRC/agrif_lim2_interp.F90 
     83  NEMOGCM/NEMO/NST_SRC/agrif_lim2_update.F90 
     84  NEMOGCM/NEMO/NST_SRC/agrif_oce.F90 
     85 
    5086=== Review Summary === 
    51 Add summary here 
     87I believe that this code has already been used by several groups with NEMO v3.2. 
     88There is an argument therefore for acceptance in v3.3.1 with these groups retesting as appropriate, assuming that the extra agrif code  
     89here is substantially unchanged from the extra code they were using. 
    5290 
    5391=== Approval for the trunk ===