Changes between Version 7 and Version 8 of ticket/0848/Review


Ignore:
Timestamp:
2011-10-05T10:05:54+02:00 (9 years ago)
Author:
sga
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/0848/Review

    v7 v8  
    7272 
    7373  NEMOGCM/NEMO/OPA_SRC/par_oce.F90 
     74    why the additional use statements for agrif: there seem to be no other changes in the body of the routine 
    7475  NEMOGCM/NEMO/LIM_SRC_2/limhdf_2.F90 
    7576    changes here would seem to be just to avoid work array clashes so would appear to belong in the trunk rather than here 
    7677 
    7778  NEMOGCM/NEMO/LIM_SRC_2/limtrp_2.F90 
     79    not really a comment for this branch, but the use of 42 separate arrays by LIM2 for properties and their moments seems a little 
     80    clumsy, particularly since they only ever seem to be used together in groups of 6.  I would suggest that since they are all module  
     81    variables and therefore allocated with their own dedicated routine that they could be rewritten as (jpi,jpj,6) arrays. 
     82    This would reduce the possibility of typing errors in the use of 42 very similar variable names, which has had to be added to  
     83    agrif_lim2_interp.F90 below. 
     84 
    7885  NEMOGCM/NEMO/LIM_SRC_2/limadv_2.F90 
    7986    more work space changes 
     
    98105    They are also declared with a 4 by 2 pattern. Why? 
    99106    There are also routine names in french (and I have nothing against this!), which would seem to be against the coding rules. 
     107    Also see comments about limtrp_2.F90 above. 
    100108 
    101109  NEMOGCM/NEMO/NST_SRC/agrif_lim2_update.F90