Changes between Version 7 and Version 8 of ticket/0848/Review

Timestamp:

2011-10-05T10:05:54+02:00 (13 years ago)

Author:

sga

Comment:

--

ticket/0848/Review

@@ -72 +72 @@
 
   NEMOGCM/NEMO/OPA_SRC/par_oce.F90
+    why the additional use statements for agrif: there seem to be no other changes in the body of the routine
   NEMOGCM/NEMO/LIM_SRC_2/limhdf_2.F90
     changes here would seem to be just to avoid work array clashes so would appear to belong in the trunk rather than here
 
   NEMOGCM/NEMO/LIM_SRC_2/limtrp_2.F90
+    not really a comment for this branch, but the use of 42 separate arrays by LIM2 for properties and their moments seems a little
+    clumsy, particularly since they only ever seem to be used together in groups of 6.  I would suggest that since they are all module 
+    variables and therefore allocated with their own dedicated routine that they could be rewritten as (jpi,jpj,6) arrays.
+    This would reduce the possibility of typing errors in the use of 42 very similar variable names, which has had to be added to 
+    agrif_lim2_interp.F90 below.
+
   NEMOGCM/NEMO/LIM_SRC_2/limadv_2.F90
     more work space changes
@@ -98 +105 @@
     They are also declared with a 4 by 2 pattern. Why?
     There are also routine names in french (and I have nothing against this!), which would seem to be against the coding rules.
+    Also see comments about limtrp_2.F90 above.
 
   NEMOGCM/NEMO/NST_SRC/agrif_lim2_update.F90