Changes between Version 1 and Version 2 of ticket/0871/Review

Timestamp:

2011-10-19T16:50:50+02:00 (13 years ago)

Author:

rblod

Comment:

--

ticket/0871/Review

@@ -21 +21 @@
 Ticket, Documentation and Code comments
 
-This development deals deals with tools development, not directly with NEMO code. Policy about tools development is a bit fuzzy, but I guess this code fits  NEMO standard with incore documentation, integration inside standard compilation environment.
+This development deals deals with tools development, not directly with NEMO code. Policy about tools development is a bit fuzzy, but I guess this code fits  NEMO standard with incore documentation, integration inside standard compilation environment. 
 
 Short documentation could be added in NEMO documentation (mpp part or specific annex).
@@ -36 +36 @@
 || Is this change expected to preserve all diagnostics? || NA ||
 || If no, is reason for the change valid/understood? || NA ||
-|| Are there significant changes in run time/memory? || YES ||[[BR]]
+|| Are there significant changes in run time/memory? || YES ||
+
 
 
@@ -47 +48 @@
 Various tests have been performed on intel with ifort compiler and IBM with xlf:
 
-- first without openmp : works fine for different kind of files (restart, outputs), if the size of the variable to rebuild doesn't exceed half of the RAM memory. For instance it fails  in the case of
-a 3D variable of dimension 300*300*50 with daily outputs during 1 year, with 8gb of RAM, the size of the vraible is more of 4Gb and has to be allocated twice (the global array and the sum of the local arrays).[[BR]]
-The old rebuild is allocating such a variable time step per time step and succeed in this case
-- with OpenMP and ifort : it fails first on execution (declaration of indimlens), after this modification (indimlens declared as SHARED), it runs fine but the rebuild fileds are not correct. Rebuild fields become correct when desactivating the nested OpenMP loops, and using OpenMP only on the number of input files. 
-- with OpenMP and xlf : runs fine for 3D fields, fails on surface fields. I didn't try to find why. In all cases it fails with big variables.
+- first without openmp : works fine for different kind of files (restart, outputs), if the size of the variable to rebuild doesn't exceed half of the RAM memory. For instance in the case of
+
+a 3D variable of dimension 300*300*50 with daily outputs during 
 
 '''Code Review'''
@@ -64 +63 @@
 
 === Review Summary ===
-
-OpenMP problems doesn't seem to be major drawback. I guess problems with ifort where more related to the support of nesting in the given implementation.[[BR]]
-I have to re-check for the 2D fields on IBM, if there is a problem, it could be fixed easily since 3D fields are OK.
-The memory problem is an issue to me, off course depending of the configuration in use.
+Add summary here
 
 === Approval for the trunk ===