New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
ticket/0972_merge_PISLOB (diff) – NEMO

Changes between Version 13 and Version 14 of ticket/0972_merge_PISLOB


Ignore:
Timestamp:
2012-08-06T16:41:33+02:00 (12 years ago)
Author:
cetlod
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • ticket/0972_merge_PISLOB

    v13 v14  
    3131'''(2)''' Improvment of PISCES ( Done by Olivier Aumont ) 
    3232 
    33  * debbuging/tuning procedure 
    34 Kriest code was not so buggy and so the debugging was pretty short. The problem was more that the results I got with this version were more or less crap ... So I did some tuning, which is by no means over. During this debuging/tuning procedure, I found some problems in the standard code which explains why there are not only changes concerning Kriest but also some other changes. I should say that these changes include also some bugs/inappropriate codings I changed some months ago. 
    3533 
    36 List of the changes/bugfixes ; o major parameterizations have been changed. It's only debugging/slight changes 
    37  
    38   - p4zbio.F90 : correction made on the update of trn to avoid marginal negative concentrations which happened with the previous coding. 
    39   - p4zlim.F90 : slight change on the minimum iron concentration small changes on the half-saturation constants for N limitation (x3 instead of x2). Bug correction on xlimbac. zlim1 should be limitation by N and not only by NH4 (bacteria can use both nh4 and NO3). 
    40   - p4zmicro : the multiplication by 2 in zrespz has been removed. Changes in the threshold computation for grazing. Grazing is now possible even for very small values of food which avoids loosing microzooplankton when food is very scarce. 
    41   - p4zmeso (ok I know, it is before p4zmicro but it was easier for the comments ) : same change as in p4zmicro for the threshold. 
    42   - p4zprod.F90 : various bug corrections (nothing serious). 
    43   - p4zrem.F90 : zbactfer has been completely rewritten 
    44   - p4zsed.F90 : P deposition has been added and is computed from dust. 
    45                 7.6 has been changed to 7.625 ( rno3 parameter ) 
    46                 The computation of the total supply by the different sources has been corrected to compute the real average. So the sums should be divided by the number of timesteps of the input file. There was no problem for the standard version but when the number of timesteps are changed in the input files (for instance monthly fields for rivers), then the budget is wrong ! 
    47   - p4zsink.F90 : bug corrections for Kriest, I have added a new xkr_nmicro for the number of elementary particles in micro end products for the kriest parameterization. This means that the namelist has changed. doc aggregation for Kriest has been changed Computation of the standard sinking speed has been changed. For this point, in fact, the correct parameterization is commented out in the standard code. I changed that to uncomment the appropriate lines. 
    48  
    49 trcnam_pisces, trcsms_pisces, ... : 7.6 -> 7.625 and perhaps some corrections. Furthermore, trcnam_pisces.F90 includes a new parameter that should be read in the namelist which is the N content of the aggregate. 
    50  
    51 I think everything is in the list. It compiles and runs smoothly. Kriest is almost tuned (i'll send the namelist when I consider this step is over which will include the changes in the namelist made for kriest). 
     34 * debbuging/tuning procedure :  
     35   - Kriest code was not so buggy and so the debugging was pretty short. The problem was more that the results I got with this version were more or less crap ... So I did some tuning, which is by no means over.  
     36     - p4zsink.F90 : bug corrections for Kriest, I have added a new xkr_nmicro for the number of elementary particles in micro end products for the kriest parameterization. This means that the namelist has changed. doc aggregation for Kriest has been changed Computation of the standard sinking speed has been changed. For this point, in fact, the correct parameterization is commented out in the standard code. I changed that to uncomment the appropriate lines. 
     37     - trcnam_pisces, trcsms_pisces, ... : 7.6 -> 7.625 and perhaps some corrections. Furthermore, trcnam_pisces.F90 includes a new parameter that should be read in the namelist which is the N content of the aggregate. 
     38     - Kriest is almost tuned (i'll send the namelist when I consider this step is over which will include the changes in the namelist made for kriest). 
     39   - List of the changes/bugfixes ; no major parameterizations have been changed. It's only debugging/slight changes : 
     40     - p4zbio.F90 : correction made on the update of trn to avoid marginal negative concentrations which happened with the previous coding. 
     41     - p4zlim.F90 : slight change on the minimum iron concentration small changes on the half-saturation constants for N limitation (x3 instead of x2). Bug correction on xlimbac. zlim1 should be limitation by N and not only by NH4 (bacteria can use both nh4 and NO3). 
     42     - p4zmicro : the multiplication by 2 in zrespz has been removed. Changes in the threshold computation for grazing. Grazing is now possible even for very small values of food which avoids loosing microzooplankton when food is very scarce. 
     43     - p4zmeso (ok I know, it is before p4zmicro but it was easier for the comments ) : same change as in p4zmicro for the threshold. 
     44     - p4zprod.F90 : various bug corrections (nothing serious). 
     45     - p4zrem.F90 : zbactfer has been completely rewritten 
     46     - p4zsed.F90 : P deposition has been added and is computed from dust ; 7.6 has been changed to 7.625 ( rno3 parameter ) ; the computation of the total supply by the different sources has been corrected to compute the real average. So the sums should be divided by the number of timesteps of the input file. There was no problem for the standard version but when the number of timesteps are changed in the input files (for instance monthly fields for rivers), then the budget is wrong ! 
    5247 
    5348 * improvment/ new parametrization 
    54  
    5549   - New Al's iron model following his paper with Christof. New module p4zfechem.F90, enabled with a namelist parameter '''ln_fechem''' 
    5650   - Introduction of a PAR variable at the ocean surface, activated by a namelist parameter '''ln_varpar'''