Changes between Version 1 and Version 2 of ticket/1296/Review

Timestamp:

2014-09-03T17:41:47+02:00 (10 years ago)

Author:

cbricaud

Comment:

--

ticket/1296/Review

@@ -7 +7 @@
 
 === Ticket Details, Documentation and Code changes ===
-||Do you understand the area of code being altered and the reasoning why it is being altered?||YES/NO||
-||Do the proposed code changes correspond with the stated reason for the change?||YES/NO||
-||Is the in-line documentation accurate and sufficient?||YES/NO||
-||Do the code changes comply with NEMO coding standards?||YES/NO||
-||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES/NO||
-||Does any corresponding external documentation require updating?||YES/NO||
-||If yes, which docs and have the updates been drafted?||YES/NO||
-||Are namelist changes required for this change?||YES/NO||
-||If yes, have they been done?||YES/NO||
-||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES/NO||
-||Does this summary correspond with your understanding of the full ticket?||YES/NO||
+||Do you understand the area of code being altered and the reasoning why it is being altered?||YES||
+||Do the proposed code changes correspond with the stated reason for the change?||YES||
+||Is the in-line documentation accurate and sufficient?||YES||
+||Do the code changes comply with NEMO coding standards?||YES||
+||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES||
+||Does any corresponding external documentation require updating?||YES||
+||If yes, which docs and have the updates been drafted?||YES||
+||Are namelist changes required for this change?||YES||
+||If yes, have they been done?||YES||
+||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES||
+||Does this summary correspond with your understanding of the full ticket?||YES||
 
 Ticket, Documentation and Code comments
 
-Add specific Ticket, Documentation and code comments here
+You will have to add the resto.nc file to the Input ORCA2 tarfile and to add its description here:
+http://www.nemo-ocean.eu/Using-NEMO/Configurations/ORCA2_LIM-and-AGRIF-demonstrator
+
+Documentation is clear
+I didn't find anywhere ( doc, website,.... ) how to compile a tool in NEMO.
+So perhaps it could be interesting to add in the doc:
+- how to compile /DMP_TOOLS/
+- how ton run it
+
 
 === Testing ===
-||Has the NVTK and other jobs been tested with this change?||YES/NO||
-||Have the required bit comparability tests been run?||YES/NO||
-||Can this change be shown to have a null impact? (if option not selected)||YES/NO||
+||Has the NVTK and other jobs been tested with this change?||YES||
+||Have the required bit comparability tests been run?||YES||
+||Can this change be shown to have a null impact? (if option not selected)||YES||
 ||If no, is reason for the change valid/understood?||YES/NO/NA||
 ||If no, ensure that the ticket details the impact this change will have on model configurations .||YES/NO/NA||
-||Is this change expected to preserve all diagnostics?||YES/NO||
+||Is this change expected to preserve all diagnostics?||YES||
 ||If no, is reason for the change valid/understood?||YES/NO/NA||
-||Are there significant changes in run time/memory?||YES/NO||
+||Are there significant changes in run time/memory?||NO||
 
 Testing Comments
@@ -40 +48 @@
 
 === Code Review ===
-||Do the code changes comply with NEMO coding standards?||YES/NO||
-||Are code changes consistent with the design of NEMO?||YES/NO||
-||Is the code free of unwanted TABs?||YES/NO||
-||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO||
+||Do the code changes comply with NEMO coding standards?||YES||
+||Are code changes consistent with the design of NEMO?||YES||
+||Is the code free of unwanted TABs?||YES||
+||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES||
 ||If no, ensure collaboration agreement has been added to the ticket keywords||||