Changes between Version 1 and Version 2 of ticket/1296/Review


Ignore:
Timestamp:
2014-09-03T17:41:47+02:00 (7 years ago)
Author:
cbricaud
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • ticket/1296/Review

    v1 v2  
    77 
    88=== Ticket Details, Documentation and Code changes === 
    9 ||Do you understand the area of code being altered and the reasoning why it is being altered?||YES/NO|| 
    10 ||Do the proposed code changes correspond with the stated reason for the change?||YES/NO|| 
    11 ||Is the in-line documentation accurate and sufficient?||YES/NO|| 
    12 ||Do the code changes comply with NEMO coding standards?||YES/NO|| 
    13 ||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES/NO|| 
    14 ||Does any corresponding external documentation require updating?||YES/NO|| 
    15 ||If yes, which docs and have the updates been drafted?||YES/NO|| 
    16 ||Are namelist changes required for this change?||YES/NO|| 
    17 ||If yes, have they been done?||YES/NO|| 
    18 ||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES/NO|| 
    19 ||Does this summary correspond with your understanding of the full ticket?||YES/NO|| 
     9||Do you understand the area of code being altered and the reasoning why it is being altered?||YES|| 
     10||Do the proposed code changes correspond with the stated reason for the change?||YES|| 
     11||Is the in-line documentation accurate and sufficient?||YES|| 
     12||Do the code changes comply with NEMO coding standards?||YES|| 
     13||Is the Ticket documented with sufficient detail for others to understand the impact of the change?||YES|| 
     14||Does any corresponding external documentation require updating?||YES|| 
     15||If yes, which docs and have the updates been drafted?||YES|| 
     16||Are namelist changes required for this change?||YES|| 
     17||If yes, have they been done?||YES|| 
     18||Has a completed Ticket Summary template been appended to the ticket to aid code reviews||YES|| 
     19||Does this summary correspond with your understanding of the full ticket?||YES|| 
    2020 
    2121Ticket, Documentation and Code comments 
    2222 
    23 Add specific Ticket, Documentation and code comments here 
     23You will have to add the resto.nc file to the Input ORCA2 tarfile and to add its description here: 
     24http://www.nemo-ocean.eu/Using-NEMO/Configurations/ORCA2_LIM-and-AGRIF-demonstrator 
     25 
     26Documentation is clear 
     27I didn't find anywhere ( doc, website,.... ) how to compile a tool in NEMO. 
     28So perhaps it could be interesting to add in the doc: 
     29- how to compile /DMP_TOOLS/ 
     30- how ton run it 
     31 
    2432 
    2533=== Testing === 
    26 ||Has the NVTK and other jobs been tested with this change?||YES/NO|| 
    27 ||Have the required bit comparability tests been run?||YES/NO|| 
    28 ||Can this change be shown to have a null impact? (if option not selected)||YES/NO|| 
     34||Has the NVTK and other jobs been tested with this change?||YES|| 
     35||Have the required bit comparability tests been run?||YES|| 
     36||Can this change be shown to have a null impact? (if option not selected)||YES|| 
    2937||If no, is reason for the change valid/understood?||YES/NO/NA|| 
    3038||If no, ensure that the ticket details the impact this change will have on model configurations .||YES/NO/NA|| 
    31 ||Is this change expected to preserve all diagnostics?||YES/NO|| 
     39||Is this change expected to preserve all diagnostics?||YES|| 
    3240||If no, is reason for the change valid/understood?||YES/NO/NA|| 
    33 ||Are there significant changes in run time/memory?||YES/NO|| 
     41||Are there significant changes in run time/memory?||NO|| 
    3442 
    3543Testing Comments 
     
    4048 
    4149=== Code Review === 
    42 ||Do the code changes comply with NEMO coding standards?||YES/NO|| 
    43 ||Are code changes consistent with the design of NEMO?||YES/NO|| 
    44 ||Is the code free of unwanted TABs?||YES/NO|| 
    45 ||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES/NO|| 
     50||Do the code changes comply with NEMO coding standards?||YES|| 
     51||Are code changes consistent with the design of NEMO?||YES|| 
     52||Is the code free of unwanted TABs?||YES|| 
     53||Has the code been wholly (100%) produced by NEMO developers working on NEMO?||YES|| 
    4654||If no, ensure collaboration agreement has been added to the ticket keywords|||| 
    4755