Changes between Version 6 and Version 7 of ticket/1464
- Timestamp:
- 2015-11-30T17:44:47+01:00 (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
ticket/1464
v6 v7 21 21 ||Other model configurations|| YES || 22 22 ||Processor configurations tested||[ 2 by 8] and [4 by 4 ]|| 23 ||If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on|| YES - see below for full details.||23 ||If adding new functionality please confirm that the [[BR]]New code doesn't change results when it is switched off [[BR]]and !''works!'' when switched on|| YES || 24 24 25 25 (Answering UNSURE is likely to generate further questions from reviewers.) … … 28 28 29 29 * All SETTE tests passed 30 * Tested SETTE configs: AMM12 AMM12_32 AMM12_LONG C1D_PAPA GYRE GYRE_4 GYRE_BFM GYRE_LONG GYRE_PISCES GYRE_XIOS ISOMIP_4 ISOMIP_LONG ORCA2AGUL_1_2 ORCA2LIM3_16 ORCA2LIM3_LONG ORCA2LIMPIS_16 ORCA2LIMPIS_LONG ORCA2OFFPIS_16 ORCA2OFFPIS_LONG ORCA2_LIM ORCA2_LIM3 ORCA2_LIM_CFC_C14b ORCA2_LIM_OBS ORCA2_LIM_PISCES ORCA2_OFF_PISCES ORCA2_SAS_LIM SAS_32 SAS_LONG 30 31 * Focused on the outputs of the ORCA2_LIM_OBS test as this is the only test using the obsoper. 31 * solver.stat and ocean.output are completely unchanged when ln_grid_global=.TRUE. 32 * solver.stat is unchanged when ln_grid_global=.FALSE. 33 * There are very small differences (order 10^-12) in the "overall RMS obs minus model of good observations" in the ocean.output when ln_grid_global=.FALSE. is used in the new code. However, these differences are of the same magntiude as the differences in output the from the trunk when ln_grid_global=.FALSE. is used compared to ln_grid_global=.TRUE. 34 * As an additional check, the obs minus background stats calculated directly from the outputted feedback files are exactly reproduced by the new code to 4 significant figures (they are likely to be exact to higher than 4 significant figures, this is the precision which we use as standard). 35 36 32 * Changes were also tested in an older version of the code at ORCA12 and were found to reduce the memory use (when ln_grid_global=.FALSE.) by more that 50%. 37 33 38 34 === Bit Comparability === 39 ||Does this change preserve answers in your tested standard configurations (to the last bit) ?|| !'''YES/NO !'''||40 ||Does this change bit compare across various processor configurations. (1xM, Nx1 and MxN are recommended)||!'''YES/NO!'''||41 ||Is this change expected to preserve answers in all possible model configurations?|| !'''YES/NO!'''||42 ||Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !''|| !'''YES/NO!'''||35 ||Does this change preserve answers in your tested standard configurations (to the last bit) ?|| YES, when ln_grid_global=.FALSE.. See below for full details|| 36 ||Does this change bit compare across various processor configurations. || YES || 37 ||Is this change expected to preserve answers in all possible model configurations?|| YES || 38 ||Is this change expected to preserve all diagnostics? [[BR]]!,,!''Preserving answers in model runs does not necessarily imply preserved diagnostics. !''||YES -see below for more detail|| 43 39 44 40 If you answered !'''NO!''' to any of the above, please provide further details: 45 41 46 * Which routine(s) are causing the difference?47 * Why the changes are not protected by a logical switch or new section-version48 * What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not.49 * What do you expect to see occur in the test harness jobs?50 * Which diagnostics have you altered and why have they changed?Please add details here........42 * solver.stat and ocean.output are completely unchanged when ln_grid_global=.TRUE. 43 * solver.stat is unchanged when ln_grid_global=.FALSE. 44 * There are very small differences (order {{{10^-12}}}) in the "overall RMS obs minus model of good observations" in the ocean.output when ln_grid_global=.FALSE. is used in the new code. However, these differences are of the same magnitude as the differences in output the from the trunk when ln_grid_global=.FALSE. is used compared to ln_grid_global=.TRUE. 45 * As an additional check, the obs minus background stats calculated directly from the outputted feedback files are exactly reproduced by the new code to 4 significant figures (they are likely to be exact to higher than 4 significant figures, this is the precision which we use as standard). 46 * No differences to the model output, although the differences in the order/distribution of the observations may lead to very tiny differences in the calculation of stats (online or offline). 51 47 48 * Which routine(s) are causing the difference? '''obs_mpp_find_obs_proc_local''' 49 * Why the changes are not protected by a logical switch or new section-version? '''I have decided to replace the obs_mpp_find_obs_proc routine with obs_mpp_find_obs_proc_local as any differences in the distribution of observations is arbitrary and should have no scientific impact.''' 50 * What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not. ''' NA ''' 51 * What do you expect to see occur in the test harness jobs? ''' NA ''' 52 * Which diagnostics have you altered and why have they changed?Please add details here........ ''' NA ''' 52 53 ---- 53 54 === System Changes === 54 ||Does your change alter namelists?|| !'''YES/NO !'''||55 ||Does your change require a change in compiler options?|| !'''YES/NO !'''||55 ||Does your change alter namelists?|| NO || 56 ||Does your change require a change in compiler options?|| NO || 56 57 57 58 If any of these apply, please document the changes required here....... … … 59 60 ---- 60 61 === Resources === 61 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!'' 62 These changes improve memory use when a large number of processors are used. For ORCA12 on 928 processors, the memory use is reduced by more than 50%.[[BR]] 63 [[BR]] 64 An ORCA025 run on 192 processors with ln_grid_global=.TRUE. uses 258 seconds wall clock and 244Gb of memory.[[BR]] 65 An ORCA025 run on 192 processors with ln_grid_global=.FALSE. and these code changes uses 265 seconds wall clock and 221Gb of memory. 62 66 63 67 ---- 64 68 === IPR issues === 65 ||Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?|| !'''YES/ NO !'''||69 ||Has the code been wholly (100%) produced by NEMO developers staff working exclusively on NEMO?|| NO || 66 70 67 71 If No:
