Changes between Version 27 and Version 28 of ticket/1593_CNRS9_NOC3_LDF
- Timestamp:
- 2015-10-05T09:31:51+02:00 (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
ticket/1593_CNRS9_NOC3_LDF
v27 v28 23 23 Three steps: [[BR]] 24 24 25 ''' I. Phasing of horizontal scale factors ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] ''' + minor correction''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737](SETTE OK)'''25 ''' I. Phasing of horizontal scale factors ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] ''' + minor correction''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] (SETTE OK)''' 26 26 27 27 ''' (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse: e1e2t, e1e2u , e1e2v, e1e2f and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 … … 29 29 ''' (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]] The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]] When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]] This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]] The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]] A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces. ===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 30 30 31 ''' [[BR]] [[BR]]II. Phasing of the advective/diffusive trends on tracers'''31 ''' [[BR]] [[BR]] II. Phasing of the advective/diffusive trends on tracers''' 32 32 33 33 '''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends : ''' '''===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' … … 119 119 '''Unresolved issues/improvement''' on TRAADV: [[BR]]- QCK: cross terms are missing. alternate direction should be added....[[BR]]- Bug in FCT with sub-time-stepping and key_vvl. The change in e3 should be taken into account in the sub-timesteps.[[BR]]- traadv_mus.F90 some rather simple optimization can be added...[[BR]]- traadv_qck.F90 : possibility to add a 4th order COMPACT scheme on the vertical. [[BR]]- 4th order COMPACT doesn't work with ISF the routine have to be modified 120 120 121 ''' (II.X)''' ..Miscellaneous :122 123 * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_ldftra_smag and associated module (ldftra_smag.F90)[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions124 125 ''' [[BR]] [[BR]]III. Phasing of viscous trends'''121 '''[[BR]]II.3''' '''Miscellaneous :''' 122 123 - Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 124 125 ''' [[BR]] [[BR]] III. Phasing of viscous trends''' 126 126 127 127 '''III.1 —''' '''LDF on dynamics''' - viscous trends : ===>>> OK see '''revision .... and ..... with SETTE OK''' 128 128 129 ''operator'': [[BR]]- laplacian operator: re-entrant laplacian for iso-level operators (routine dyn_ldf_lap found in dynldf_lap_blp);[[BR]]- bilaplacian operator: dynldf_blp.F90 module: use of the re-entrant iso-level laplacian (routine dyn_ldf_blp found in dynldf_lap_blp.F90)[[BR]]- suppression of dynnept.F90 129 ''operator'': [[BR]]- laplacian operator: re-entrant laplacian for iso-level operators (routine dyn_ldf_lap found in dynldf_lap_blp);[[BR]]- bilaplacian operator: dynldf_blp.F90 module: use of the re-entrant iso-level laplacian (routine dyn_ldf_blp found in dynldf_lap_blp.F90)[[BR]]- suppression of dynnept.F90 to finalize the suppression of Neptune effect param. ;[[BR]]- suppression of dynldf_lap.F90 and dynldf_bilap.F90 replaced by dynldf_lap_blp.F90 (which contains dyn_ldf_lap & dyn_ldf_blp routines) ; dynldf_bilapg.F90 (remove old and approximative rotated bi-laplacian on momentum)[[BR]]- rotb and rotn arrays suppressed (even from the restart file) NB: the viscous operator now uses the full before velocity field (i.e. including the asselin filter)[[BR]]- hdivb array is suppressed. hdivn and hdivb are removed from restart[[BR]]- associate with rotn and rotb suppression comes the suppression of no-slip accurate option (key_noslip_accurate is removed)[[BR]]- divcur.F90 becomes divhor.F90 and only computes the horizontal divergence 130 130 131 131 [[BR]]''lateral mixing coefficient'':[[BR]]- new user interface (namelist) : … … 159 159 / 160 160 }}} 161 [[BR]]- default value of the namelist: ''no operator chosen'': ln_dynldf_lap=dyndf_blp=0 No lateral diffusion applied on momentum '''===>>> check THAT'''[[BR]]- create the 2D and 3D ahtu and ahtv file for ORCA_R2 '''===>>> TO BE DONE for ORCA_R1''' . nn_ahm_ijk_t must be set to -20 or -30 for ORCA2 and ORCA1 (read in a file) [[BR]]- both laplacian and bi-laplacian coef. are always 3D arrays defined at T- and F- points. Bi-laplacian eddy coefficient defined as SQRT(bhm) [[BR]]''' ====>>> TO BE DONE: explore the possibility of u- and v-points'''[[BR]]- redesign of space variation of the eddy viscosity: suppression of: ldfdyn_substitute.h90 ; ldfdyn_c1d.h90 , ldfdyn_c2d.h90 and ldfdyn_c3d.h90 (replaced by ldfc1d_c2d.F90, a module share with ldftra.F90) ; ldfdyn_oce.F90 (now included in ldfdyn.F90)[[BR]]- remove ldfdyn_smag.F90 (suppression of smagorinsky option) '''==>>> TO BE re-add in the new framework by someone...'''[[BR]]- suppression of key_esopa in dynldf.F90[[BR]]- suppression of key_dynldf_c1d, key_dynldf_c2d, key_dynldf_c3d[[BR]]- change in all standard namelist_cfg and 1_namelist_cfg ''' ===>>> TO BE DONE''' 161 [[BR]]- default value of the namelist: ''no operator chosen'': ln_dynldf_lap=dyndf_blp=0 ==>>> No lateral diffusion applied on momentum[[BR]]- create the 2D and 3D ahmt and ahmf file for ORCA_R2 '''===>>> TO BE DONE for ORCA_R1''' . nn_ahm_ijk_t must be set to -20 or -30 for ORCA2 and ORCA1 (read in a file) [[BR]]- both laplacian and bi-laplacian coef. are always 3D arrays defined at T- and F- points. Bi-laplacian eddy coefficient defined as SQRT(bhm) [[BR]]''' ====>>> TO BE DONE: explore the possibility of u- and v-points'''[[BR]]- redesign of space variation of the eddy viscosity: suppression of: ldfdyn_substitute.h90 ; ldfdyn_c1d.h90 , ldfdyn_c2d.h90 and ldfdyn_c3d.h90 (replaced by ldfc1d_c2d.F90, a module share with ldftra.F90) ; ldfdyn_oce.F90 (now included in ldfdyn.F90)[[BR]]- remove ldfdyn_smag.F90 (suppression of smagorinsky option) '''==>>> TO BE re-add in the new framework by someone...'''[[BR]]- suppression of key_esopa in dynldf.F90[[BR]]- suppression of key_dynldf_c1d, key_dynldf_c2d, key_dynldf_c3d[[BR]]- change in all standard namelist_cfg and 1_namelist_cfg ''' ===>>> TO BE DONE'''[[BR]]- Namelist default values : NO operator ; NO direction ===>>> No lateral mixing applied on momentum ===>>> must be specified in all CONFIG '''===>>> TO BE DONE''' 162 163 '''[[BR]]III.2 —''' '''ADV on dynamics''' - advective trends : ===>>> OK see '''revision .... and ..... with SETTE OK''' 164 165 ''dynvor.F90''[[BR]] - remove key_esopa[[BR]] - remove dyn_vor_mix : now successive call of den_vor_ene (Coriolis) and din_vor_ens (relative voricity)[[BR]] - replace rotn by its calculation everywhere in dynvor.F90[[BR]] - remove the use of fmask everywhere in dynvor.F90 '''=====>>>> TO BE DONE: verify this with Florian '''[[BR]] - 166 167 ''dynadv.F90[[BR]]''- remove key_esopa[[BR]] 168 169 '''[[BR]]II.3''' '''Miscellaneous :''' 170 171 - ... 162 172 163 173 [[BR]]'''IV. Solve the pending issues''' 164 174 165 ''' (IV.1) ''' specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]] Issue: define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]] Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]] and use this scalar to compute the grid-size dependency of the coefficients. [[BR]] ''' (IV.2) ''' specification of lateral friction at the coast.[[BR]] Issue: the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term (''' double check that''' !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]] Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]] and use this scalar to compute the grid-size dependency of the coefficients. [[BR]] ''' (IV.3)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity175 ''' (IV.1) ''' specification of eddy viscosity/diffusivity coefficients in case of grid-size dependency.[[BR]] Issue: define the grid-size dependency in such a way that does not require the Equator being inside the domain.[[BR]] Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]] and use this scalar to compute the grid-size dependency of the coefficients. [[BR]] ''' (IV.2) ''' specification of lateral friction at the coast.[[BR]] Issue: the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term (''' double check that''' !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]] Solution: add a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain[[BR]] and use this scalar to compute the grid-size dependency of the coefficients. [[BR]] ''' (IV.3)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity[[BR]](IV.4) It should be possible to remove hdivn ... think about that 166 176 167 177 ... … … 171 181 * '''IV.1 '''In case of variation of the 2D coeff. as a function of the grid size, use a reference to a 1 degree grid size for ah on both tracers and momentum 172 182 * '''IV.2''' management of no-slip boundary condition as fmask no more used in dynvor.F90 .... 173 * '''IV.3''' re-introduce in a consistent way with the re-design LDF if decided...183 * '''IV.3''' re-introduce Smagorinsky coefficient in a consistent way with the re-design LDF if decided... 174 184 * 175 185 * test with SETTE (especially restartability and reproducibility ) 176 186 177 [[BR]] '''V. Finalize the simplification'''178 179 ''' (V.1) add''' in NEMOGCM/TOOLS directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]] ''' (V.2) create''' the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°, ''' 1/2° and 1/4° missing''' ...[[BR]] ''' (V.3) create''' in NEMOGCM/TOOLS directory a program that create the ORCA2 and ORCA1 eddy viscosity'''????'''187 [[BR]] ''' V. Finalize the simplification''' 188 189 ''' (V.1) add''' in NEMOGCM/TOOLS directory a program that read a coordinates.nc file apply a reduction of scale factors in some straits, and create the associated extended coordinates file (coordinates_e1e2u_v.nc).[[BR]] ''' (V.2) create''' the extended coordinates files form ORCA 2°, 1°, and 0.5°. ===>>> Done for ORCA 2° and 1°, ''' 1/2° and 1/4° missing''' ...[[BR]] ''' (V.3) create''' in NEMOGCM/TOOLS directory a program that create the ORCA2 and ORCA1 eddy viscosity''' ????''' 180 190 181 191 ... … … 191 201 * Bug in diawri.F90 when NOT using key_iomput (OK ==>> see ticket #1596) 192 202 193 * Idea for finalization of domhgr.F90 :[[BR]]'''add''' 2 modules (from domhgr.F90), domhgr_read.F90 and domhgr_ana.F90, which contains:[[BR]]- domhgr_read.F90: the CASE jphgr_msh=0 of domhgr.F90 (i.e. read the coordinates file)[[BR]]- domhgr_ana.F90: the CASE jphgr_msh=5 of domhgr.F90 (i.e. the GYRE analytical definition of the coordinates)[[BR]]'''add''' in NEMOGCM/TOOLS a directory containing 3 domhgr_ana.F90 modules associated with (1) a geographical mesh on the sphere with regular (in degree) grid-spacing (jphgr_msh=1) ; (2) f- or beta-plane with regular grid-spacing (jphgr_msh=2 or 3)) ; (3) geographical mesh on the sphere, isotropic MERCATOR type (jphgr_msh=4)[[BR]]'''remove''' from the namelist_ref/namdom all variable related to the horizontal mesh, and add a flag, ln_mesh_read, =T read the coordinates.nc file ; =F analytical mesh (by default GYRE mesh).[[BR]][[BR]] 203 * Idea for finalization of domhgr.F90 :[[BR]]'''add''' 2 modules (from domhgr.F90), domhgr_read.F90 and domhgr_ana.F90, which contains:[[BR]]- domhgr_read.F90: the CASE jphgr_msh=0 of domhgr.F90 (i.e. read the coordinates file)[[BR]]- domhgr_ana.F90: the CASE jphgr_msh=5 of domhgr.F90 (i.e. the GYRE analytical definition of the coordinates)[[BR]]'''add''' in NEMOGCM/TOOLS a directory containing 3 domhgr_ana.F90 modules associated with (1) a geographical mesh on the sphere with regular (in degree) grid-spacing (jphgr_msh=1) ; (2) f- or beta-plane with regular grid-spacing (jphgr_msh=2 or 3)) ; (3) geographical mesh on the sphere, isotropic MERCATOR type (jphgr_msh=4)[[BR]]'''remove''' from the namelist_ref/namdom all variable related to the horizontal mesh, and add a flag, ln_mesh_read, =T read the coordinates.nc file ; =F analytical mesh (by default GYRE mesh). 204 * sbcisf.F90 : use of hard coded staff associated with EOS (in situ temperature and co ...) 205 * sbcwave.F90 : lot of modifications has been done, but I'm still uncomfortable with the calculation of stokes drift velocities....[[BR]][[BR]] 194 206 195 207 ...
