Changes between Version 35 and Version 36 of ticket/1593_CNRS9_NOC3_LDF
- Timestamp:
- 2015-10-24T14:17:04+02:00 (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
ticket/1593_CNRS9_NOC3_LDF
v35 v36 23 23 Three steps: [[BR]] 24 24 25 ''' I. Phasing of horizontal scale factors ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] ''' + minor correction''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737](SETTE OK)'''25 ''' I. Phasing of horizontal scale factors ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] ''' + minor correction''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5737] (SETTE OK)''' 26 26 27 27 ''' (I.1)''' standardisation of the name of quantities derived from horizontal scale factors (many modules of NEMO)[[BR]]The chosen names of quantities derived from horizontal scale factors are:[[BR]]- inverse of scale factors : r1_e1t, r1_e2t, r1_e1u, r1_e2u, r1_e1v, r1_e2v, r1_e1f, r1_e2f ;[[BR]]- surfaces and their inverse: e1e2t, e1e2u , e1e2v, e1e2f and, r1_e1e2t , r1_e1e2u , r1_e1e2v, r1_e1e2f ;[[BR]]- ratio (used in traldf...) : e2_e1u , e1_e2v(I.1) generalize of the use of surface scale factors ;[[BR]]These quantities are defined in memory in dom_oce.F90, and set to their proper value in domhgr.F90 … … 29 29 ''' (I.2)''' add a optional read of surface scale factors at velocity points in coordinate file (domhgr.F90)[[BR]] The input coordinate file have to include e1e2u and e1e2v in case of reduction of the scale factors in some straits.[[BR]] When e1u or e2v are reduced in some straits, the surface at u- and v-points remains unchanged.[[BR]] This allows to suppress the dom_vvl_orca_fix routine from dlmvvl.F90 module.[[BR]]''Note that this change modifies the model results'', as it contains a better handling of reduced strait width (i.e. reduced surface between 2 adjacent U or V points, but unchanged U and V points volume).[[BR]] The implementation performed here is a first step to the full simplification of domhgr.F90. We kept here the hard coded reduction of scale factor in some straits for some given ORCA configuration. [[BR]] A last step (see IV) will be to suppress the hard coded reduction of some scale factor as it will be always given in the coordinates.nc file together with the e1e2u & e1e2v surfaces. ===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5755]''' 30 30 31 ''' [[BR]] [[BR]]II. Phasing of the advective/diffusive trends on tracers'''31 ''' [[BR]] [[BR]] II. Phasing of the advective/diffusive trends on tracers''' 32 32 33 33 '''II.1 —''' '''LDF on tracers''' (both TRA & TRC) - Diffusive trends : ''' '''===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5758] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5759] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5760] with SETTE OK''' … … 123 123 * Atmospheric pressure forcing: change to a systematic call of sbc_apr in step.F90 (with or without BDY) and remove its call from sbcmod[[BR]]- remove key_vectopt_loop from all the code except in domzgr_substitute.h90 (it is an obsolescent feature only adapted to vector computers)[[BR]]- remove all "!CDIR " lines = NEC vector compiler instructions 124 124 125 ''' [[BR]] [[BR]] III. Phasing of momentum trends ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5777] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5778] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5737 5782]with SETTE OK'''125 ''' [[BR]] [[BR]] III. Phasing of momentum trends ''' ===>>> OK see ''' revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5777 5777] & [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778] and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5782 5782] with SETTE OK''' 126 126 127 127 '''III.1 —''' '''LDF on dynamics''' - viscous trends … … 161 161 [[BR]]- default value of the namelist: ''no operator chosen'': ln_dynldf_lap=dyndf_blp=0 ==>>> No lateral diffusion applied on momentum[[BR]]- create the 2D and 3D ahmt and ahmf file for ORCA_R2 '''===>>> TO BE DONE for ORCA_R1''' . nn_ahm_ijk_t must be set to -20 or -30 for ORCA2 and ORCA1 (read in a file) [[BR]]- both laplacian and bi-laplacian coef. are always 3D arrays defined at T- and F- points. Bi-laplacian eddy coefficient defined as SQRT(bhm) [[BR]]''' ====>>> TO BE DONE: explore the possibility of u- and v-points'''[[BR]]- redesign of space variation of the eddy viscosity: suppression of: ldfdyn_substitute.h90 ; ldfdyn_c1d.h90 , ldfdyn_c2d.h90 and ldfdyn_c3d.h90 (replaced by ldfc1d_c2d.F90, a module share with ldftra.F90) ; ldfdyn_oce.F90 (now included in ldfdyn.F90)[[BR]]- remove ldfdyn_smag.F90 (suppression of smagorinsky option) '''==>>> TO BE re-add in the new framework by someone...'''[[BR]]- suppression of key_esopa in dynldf.F90[[BR]]- suppression of key_dynldf_c1d, key_dynldf_c2d, key_dynldf_c3d[[BR]]- change in all standard namelist_cfg and 1_namelist_cfg [[BR]]- Namelist default values : NO operator ; NO direction ===>>> No lateral mixing applied on momentum ===>>> must be specified in all CONFIG 162 162 163 '''[[BR]]III.2 —''' '''ADV on dynamics''' - advective trends : ===>>> OK see '''revision .... and ..... with SETTE OK'''164 165 ''dynvor.F90 (impact also dynspg_ts.F90)''[[BR]] - remove key_esopa[[BR]] - remove dyn_vor_mix : now successive call of den_vor_ene (Coriolis) and din_vor_ens (relative voricity)[[BR]] - replace rotn by its calculation everywhere in dynvor.F90[[BR]] - remove the use of fmask from standard vorticity calculation in dynvor.F90 but add a namelist parameter (ln_dynvor_msk) to multiply by fmask the vorticity term[[BR]]- add an namelist option to mask or not the vorticity (including Coriolis) 163 '''[[BR]]III.2 —''' '''ADV on dynamics''' - advective trends : ===>>> OK see '''revision [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5778 5778]''' and [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5786 5786]with SETTE OK 164 165 ''dynvor.F90 (impact also dynspg_ts.F90)''[[BR]] - remove key_esopa[[BR]] - remove dyn_vor_mix : now successive call of den_vor_ene (Coriolis) and din_vor_ens (relative voricity)[[BR]] - replace rotn by its calculation everywhere in dynvor.F90[[BR]] - remove the use of fmask from standard vorticity calculation in dynvor.F90 but add a namelist parameter (ln_dynvor_msk) to multiply by fmask the vorticity term[[BR]]- add an namelist option to mask or not the vorticity (including Coriolis) '''CAUTION''' : the mask option does not work: set to FALSE by default with comment DO NOT set it to TRUE (see ''' [https://forge.ipsl.jussieu.fr/nemo/log/branches/2015/dev_r5721_CNRS9_NOC3_LDF?rev=5827 5827]''' )[[BR]]- change ln_dynvor_een_old into nn_een_e3f = 0/1 166 166 167 167 namdyn_vor becomes: … … 181 181 ''dynadv.F90[[BR]]''- remove key_esopa[[BR]]- introduce parameter in the SELECT CASE 182 182 183 Many modules (both in OPA_SRC and TOP) : remove key_esopa from all the NEMO system184 185 183 namlist_ref and all CONFIG namelists updated 186 184 … … 203 201 '''• '''specification of lateral friction at the coast.[[BR]]Issue: the different values of fmask at the coast have been removed so that this lateral boundary condition doesn't affect the advective term (''' double check that''' !). fmask is still used for laplacian and bilaplacian viscosities. Nevertheless, the magnitude of lateral friction depends on the magnitude of ahm (bhm, reap.). It seems better to define this magnitude [[BR]]Solution: [[BR]]- '''add''' a scalar in the coordinate file which is equal to the grid-size at the equator even if Equator is not in the domain and use this scalar to compute the grid-size dependency of the coefficients. 204 202 205 ''' [[BR]] [[BR]]V. Pending issues : to be solved in 2016 ?'''203 ''' [[BR]] [[BR]] V. Pending issues : to be solved in 2016 ?''' 206 204 207 205 '''(V.1)''' Add a proper coding of Smagorinsky eddy viscosity and diffusivity... … … 209 207 '''(V.2)''' It should be possible to remove hdivn ... think about that 210 208 211 [[BR]] '''Next Step :'''209 [[BR]] ''' Next Step :''' 212 210 213 211 Starting from this branch, another branch is created ('''given the name here''') which will contain the following item (random order): … … 263 261 If you answered !'''NO!''' to any of the above, please provide further details: 264 262 265 * Which routine(s) are causing the difference? 263 * Which routine(s) are causing the difference? all LDF and DYN/TRA advection/diffusion modules 266 264 * Why the changes are not protected by a logical switch or new section-version : changes affect the deep kernel of the code 267 265 * What is needed to achieve regression with the previous model release (e.g. a regression branch, hand-edits etc). If this is not possible, explain why not. … … 274 272 || Does your change require a change in compiler options? || NO || 275 273 276 If any of these apply, please document the changes required here : see above in 274 If any of these apply, please document the changes required here : see above in '''Description''' 277 275 278 276 ---- 279 277 === Resources === 280 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!'' 278 !''Please !''summarize!'' any changes in runtime or memory use caused by this change......!'' :-) 281 279 282 280 ----
