Changes between Version 11 and Version 12 of ticket/1620_MERCATOR_SOLVER_SIMPLIFICATION

Timestamp:

2015-11-20T16:40:37+01:00 (8 years ago)

Author:

gm

Comment:

--

ticket/1620_MERCATOR_SOLVER_SIMPLIFICATION

@@ -7 +7 @@
 '''Step 1: Remove filtered free surface option and associated key_dynspg_flt key'''
 
-  1) Remove parts of the code specific to "key_dynspg_flt" or lk_dynspg_flt=T and the need for solver modules in the code.[[BR]]          2) Suppress SOL directory and dynspg_flt module[[BR]]
+  1) Remove parts of the code specific to "key_dynspg_flt" or lk_dynspg_flt=T and the need for solver modules in the code.[[BR]]                2) Suppress SOL directory and dynspg_flt module[[BR]]
 
 3) Clean momentum trend routines related to filtered free surface (trddyn, trdken, trd_oce).[[BR]] 4) Update reference configurations: [[BR]]
@@ -55 +55 @@
 '''Step 4: Additional things to do:'''
 
+ * Answering Gurvan' review :
+
+change in namelist :
+
+remove both  '''key_dynspg_exp'''  and '''key_dynspg_ts''', create instead namdyn_spg with ln_dynspg_exp  and ln_dynspg_ts   and all the namsplit namelist + change in some names (ln_bt_nn_auto  becomes ln_bt_auto) :
+
+{{{
+!-----------------------------------------------------------------------
+&namdyn_spg      !  surface pressure gradient computation
+!-----------------------------------------------------------------------
+   ln_dynspg_exp = .FALSE.   !  explicit free surface
+   ln_dynspg_ts  = .FALSE.   !  split-explicit free surface
+      ln_bt_fw   = .TRUE.    !  Forward integration of barotropic Eqs.
+      ln_bt_av   = .TRUE.    !  Time filtering of barotropic variables
+         nn_bt_flt =    1       !  Time filter choice  = 0 None
+         !                      !                      = 1 Boxcar over   nn_baro sub-steps
+         !                      !                      = 2 Boxcar over 2*nn_baro  "    "
+      ln_bt_auto  = .TRUE.   !  number of sub-step defined from:
+         rn_bt_cmax =  0.8      ! =T : the Maximum Courant Number allowed
+         nn_baro    = 30        ! =F : the number of sub-step in rn_rdt seconds
+/
+
+}}}
+Note that ln_dynspg_exp =  ln_dynspg_ts = .FALSE. in the ref namelist so that this namelist should be systematical fill up in cfg namelist.
+
+I don't understand the difference between  nn_bt_flt=0  and ln_bt_av=F ....???
+
+Note that array of time-splitting part should only be allocated if ln_dynspg_ts=TRUE
+
+dynspg_exp   should be modified so that it return the after velocity as dynspg_ts    ===>>> simplify dynnxt.F90
+
+dynspg_oce  should be suppressed : all variables should be declared either in dynspg.F90 (ln_dynspg_exp and ln_dynspg_ts) or in dynspg_ts for the others
+
+[[BR]]Step.F90   further simplification are needed here :
+
+with removal of solver the DYNAMICS should always be called first ! even in case of explicit free surface !!!!!
+
+The only 2 differences is that in explicit free surface un,vn are not updated after the dynamics, and domvvl is called before the dynamics instead of after the dynamics (or in-between if you don’t follow the remark just below)
+
+Q? why splitting the Dynamics in two parts?  make the approximation dz(Ua) computed with e3uw_n ? to be tested …
+
+Furthermore, you can notice that ua,va are no more used as workspace in the tracers, ua_sv and va_sn are no more needed , no?
+
  * Correct momentum trend computation with time splitting (Gurvan, your input here ?)
  * Remove filtered free surface from documentation