| 57 | * Answering Gurvan' review : |
| 58 | |
| 59 | change in namelist : |
| 60 | |
| 61 | remove both '''key_dynspg_exp''' and '''key_dynspg_ts''', create instead namdyn_spg with ln_dynspg_exp and ln_dynspg_ts and all the namsplit namelist + change in some names (ln_bt_nn_auto becomes ln_bt_auto) : |
| 62 | |
| 63 | {{{ |
| 64 | !----------------------------------------------------------------------- |
| 65 | &namdyn_spg ! surface pressure gradient computation |
| 66 | !----------------------------------------------------------------------- |
| 67 | ln_dynspg_exp = .FALSE. ! explicit free surface |
| 68 | ln_dynspg_ts = .FALSE. ! split-explicit free surface |
| 69 | ln_bt_fw = .TRUE. ! Forward integration of barotropic Eqs. |
| 70 | ln_bt_av = .TRUE. ! Time filtering of barotropic variables |
| 71 | nn_bt_flt = 1 ! Time filter choice = 0 None |
| 72 | ! ! = 1 Boxcar over nn_baro sub-steps |
| 73 | ! ! = 2 Boxcar over 2*nn_baro " " |
| 74 | ln_bt_auto = .TRUE. ! number of sub-step defined from: |
| 75 | rn_bt_cmax = 0.8 ! =T : the Maximum Courant Number allowed |
| 76 | nn_baro = 30 ! =F : the number of sub-step in rn_rdt seconds |
| 77 | / |
| 78 | |
| 79 | }}} |
| 80 | Note that ln_dynspg_exp = ln_dynspg_ts = .FALSE. in the ref namelist so that this namelist should be systematical fill up in cfg namelist. |
| 81 | |
| 82 | I don't understand the difference between nn_bt_flt=0 and ln_bt_av=F ....??? |
| 83 | |
| 84 | Note that array of time-splitting part should only be allocated if ln_dynspg_ts=TRUE |
| 85 | |
| 86 | dynspg_exp should be modified so that it return the after velocity as dynspg_ts ===>>> simplify dynnxt.F90 |
| 87 | |
| 88 | dynspg_oce should be suppressed : all variables should be declared either in dynspg.F90 (ln_dynspg_exp and ln_dynspg_ts) or in dynspg_ts for the others |
| 89 | |
| 90 | [[BR]]Step.F90 further simplification are needed here : |
| 91 | |
| 92 | with removal of solver the DYNAMICS should always be called first ! even in case of explicit free surface !!!!! |
| 93 | |
| 94 | The only 2 differences is that in explicit free surface un,vn are not updated after the dynamics, and domvvl is called before the dynamics instead of after the dynamics (or in-between if you don’t follow the remark just below) |
| 95 | |
| 96 | Q? why splitting the Dynamics in two parts? make the approximation dz(Ua) computed with e3uw_n ? to be tested … |
| 97 | |
| 98 | Furthermore, you can notice that ua,va are no more used as workspace in the tracers, ua_sv and va_sn are no more needed , no? |
| 99 | |