Changes between Version 22 and Version 23 of Branches/MergeOCN/Goll

Timestamp:

2015-05-27T09:08:53+02:00 (9 years ago)

Author:

dgoll

Comment:

--

Branches/MergeOCN/Goll

@@ -196 +196 @@
 
 
-= Bugs not fixed =
-== '''1. Mass conservation issue: stomate_phenology.f90''' ==
-detected, but not fixed yet
-This piece of code leads that less biomass is allocated to leaf and root than was subtracted earlier from labile and rescarb using variable bm_use; 
-I guess this mass leak is related to the in code comment. New DOFOCO code in MERGE-OCN 2698 does not fix this problem.
+
+== '''6. Mass conservation issue: stomate_phenology.f90''' ==
+When calculating the share of new biomass to leaves (Cl_init) and roots (Cr_init) of each circ_class, the biomass has to be divided by the number of tree per class (circ_class_n)
+
 {{{                 
-                      ! +++CHECK+++
+                      ! Distribute the biomass over the leaves and roots (gC tree-1)
+                      ! Use Cl_init to estimate the share for each circumference class
+                      ! leaf biomass = FK * Cs / height (allometric relationship)
+                      ! root biomass = KF / LF * Cs / height
+                      ! Convert from gC m-2 to gC tree-1
+
+                      ! +++CHECK+++ 
                       ! Cl_init + Cr_init can  exceed bm_use. bm_use should be used in these equations
-                      circ_class_biomass(i,j,l,ileaf,icarbon) = circ_class_biomass(i,j,l,ileaf,icarbon) + &
-                           Cl_init * ( KF(i,j) * Cs_tree(l) / height(i,j,l) * circ_class_n(i,j,l) ) / &
-                           SUM( KF(i,j) * Cs_tree(:) / height(i,j,:) * circ_class_n(i,j,:) )
-
-                      circ_class_biomass(i,j,l,iroot,icarbon) = circ_class_biomass(i,j,l,iroot,icarbon) + &
-                           Cr_init * ( KF(i,j) * Cs_tree(l) / height(i,j,l) * circ_class_n(i,j,l) ) / &
-                           SUM( KF(i,j) * Cs_tree(:) / height(i,j,:) * circ_class_n(i,j,:) )
-                      !++++++++++++
-                  
-
-              
+                      ! DSG: I cannot confirm the statement in the line before
+                      ! but the equation were wrong, the biomass has to be divided by numbers of tree (circ_class_n)
+
+                       circ_class_biomass(i,j,l,ileaf,icarbon) = circ_class_biomass(i,j,l,ileaf,icarbon) + &
+                            Cl_init * ( KF(i,j) * Cs_tree(l) / height(i,j,l) * circ_class_n(i,j,l) ) / &
+                       !DSGdebug_06     SUM( KF(i,j) * Cs_tree(:) / height(i,j,:) * circ_class_n(i,j,:) )
+                            SUM( KF(i,j) * Cs_tree(:) / height(i,j,:) * circ_class_n(i,j,:) ) / circ_class_n(i,j,l)
+                       !DSGdebug_06     
+
+                       circ_class_biomass(i,j,l,iroot,icarbon) = circ_class_biomass(i,j,l,iroot,icarbon) + &
+                            Cr_init * ( KF(i,j) * Cs_tree(l) / height(i,j,l) * circ_class_n(i,j,l) ) / &
+                      !DSGdebug_06      SUM( KF(i,j) * Cs_tree(:) / height(i,j,:) * circ_class_n(i,j,:) )
+                            SUM( KF(i,j) * Cs_tree(:) / height(i,j,:) * circ_class_n(i,j,:) ) / circ_class_n(i,j,l)
+                       !DSGdebug_06     
+                      !++++++++++++            
 }}}