Changes between Version 28 and Version 29 of Branches/MergeOCN/Goll

Timestamp:

2015-05-27T14:37:40+02:00 (9 years ago)

Author:

dgoll

Comment:

--

Branches/MergeOCN/Goll

@@ -180 +180 @@
              bm_alloc_tot(ipts,j) = bm_alloc_tot(ipts,j) - residual(ipts,j)
 !DSGdebug_05
-
-
-
-
-}}}
+}}}
+[...]
 {{{
 !DSGdebug_05
@@ -190 +187 @@
            bm_alloc(:,j,k,icarbon) = f_alloc(:,j,k) * bm_alloc_tot(:,j)  ! residual was already removed from bm_alloc_tot
 !DSGdebug_05
+}}}
+Further changes needed regarding residual to ensure mass conservation:
+1. The residual has to be initialized with zero:
+{{{
+    ! If npp is not initialized, bare soil value is never set.
+    npp(:,:) = zero
+
+!DSGdebug_05a    ! Not having this results in an unitilized error
+!DSGdebug_05a    ! with valgrid, but I can't figure out why.  It always
+!DSGdebug_05a    ! seems to be set before being used.
+     ! DSG: Of course you get errors, when a variable was never set but is used
+     ! (for example in case first_call=true)
+     ! I set it to zero, as it should be zero in the aformentioned case
+!DSGdebug_05a    residual(:,:) = val_exp
+!DSGdebug_05a 
+     residual(:,:) = zero
+!DSGdebug_05a 
+}}}
+2. In case of nutrient down regulating bm_alloc the labile pool has to be corrected for not allocated residual
+{{{
+    !DSGdebug_01
+    biomass(:,:,ilabile,:)   = biomass(:,:,ilabile,:)   - alloc_tot(:,:,:)
+    !DSGdebug_01
+
+    !DSGdebug_05a
+    WHERE ((residual(:,:).GT. zero).AND.(residual(:,:) .GT. bm_alloc_tot(:,:)))
+        biomass(:,:,ilabile,icarbon)  = biomass(:,:,ilabile,icarbon)   - (residual(:,:) - bm_alloc_tot(:,:))
+    END WHERE
+    !DSGdebug_05a
+
 }}}