wiki:Branches/MergeOCN/Peng

Version 4 (modified by speng, 9 years ago) (diff)

--

Shushi page

Bugs in MERGE-OCN (r2558)

  1. corrected in slowproc.f90

line 4972, soiltext ---> soilbulk

line 4975, soiltext ---> soilph

  1. corrected bug as ticket#109
  1. corrected bug for "carbon"initialization, actually, this variable should contain a element dimension in the calculation, at least icarbon and initrogen. So it is better to rename this variable as ele_pools...

in stomate_io.f90

 232 !!!!pssdebugok#1+++
 233     REAL(r_std), DIMENSION(npts,ncarb,nvm,nelements), INTENT(out)       :: carbon                  !! som pool: active, slow, or passive, surface
 234                                                                                                    !! for carbon and nitrogen (gC/m**2)
 235 !!!!pssdebugok#1---
 236 !    REAL(r_std), DIMENSION(npts,ncarb,nvm), INTENT(out)                 :: carbon                  !! carbon pool: active, slow, or passive,
 237 !                                                                                                   !! (gC/m**2)

  1. leaching only have iammonium and initrate, other gas (inox, initrous) for leaching should be zero;

in stomate_soilcarbon.f90

debug: initiate leaching(:,:,:) = 0

 654 !!!!pssdebug++++
 655     leaching(:,:,:) = 0
 656 !!!!pssdebug----

For denitrification calculation, there is no leaching(:,m,inox) and leaching(:,m,initrous) calculation before. I think we do not need to minus leaching for this two species here.

1079 !!!!pssdebugok+          !
1080           ! NO consumption
1081           denitrification(:,m,i_nh4_to_no) = MIN(soil_n_min(:,m,inox), &
1082                anvf(:,m) * ( mu_no(:) / Y_no + M_no * soil_n_min(:,m,inox) / sum_n(:)) * bact(:,m) * &
1083                24. * dt )
1084           !
1085           ! N2O consumption
1086           denitrification(:,m,i_nh4_to_n2o) = MIN(soil_n_min(:,m,initrous), &
1087                anvf(:,m) * ( mu_n2o(:) / Y_n2o + M_n2o * soil_n_min(:,m,initrous) / sum_n(:)) * bact(:,m) * &
1088                24. * dt )
1089 !!!!pssdebugok-  
1090 !!!!pssdebug          ! NO consumption
1091 !!!!pssdebug          denitrification(:,m,i_nh4_to_no) = MIN(soil_n_min(:,m,inox)-leaching(:,m,inox), &
1092 !!!!pssdebug               anvf(:,m) * ( mu_no(:) / Y_no + M_no * soil_n_min(:,m,inox) / sum_n(:)) * bact(:,m) * &
1093 !!!!pssdebug               24. * dt )        
1094 !!!!pssdebug          !
1095 !!!!pssdebug          ! N2O consumption
1096 !!!!pssdebug          denitrification(:,m,i_nh4_to_n2o) = MIN(soil_n_min(:,m,initrous)-leaching(:,m,initrous), &
1097 !!!!pssdebug               anvf(:,m) * ( mu_n2o(:) / Y_n2o + M_n2o * soil_n_min(:,m,initrous) / sum_n(:)) * bact(:,m) * &
1098 !!!!pssdebug               24. * dt )

  1. nitrogen demand problem