Changes between Version 58 and Version 59 of DevelopmentActivities/ORCHIDEE-DOFOCO


Ignore:
Timestamp:
2016-02-03T17:07:22+01:00 (8 years ago)
Author:
luyssaert
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • DevelopmentActivities/ORCHIDEE-DOFOCO

    v58 v59  
    3030- The code crashes in stomate_growth_fun_alloc.f90. 
    3131 
    32 === 27.01.2015 === 
     32=== 27.01.2016 === 
    3333- Fixed the crashes in stomate_growth_fun_alloc.f90. Mass balance is now closed for carbon and nitrogen and biomass and circ_class_biomass are synchronized for carbon. Need a longer test to check whether nitrogen is also in sync.  
    3434 
     35=== 03.02.2016 === 
     36- A very basic version of the model (i.e., prescribe, phenology, allocation and all of sechiba) runs for 10 year (end of test) on a single pixel for all PFTs (without crops). The mass balance is closed for N and C and the different biomass variables are synchronized. 
     37- The evergreen PFTs respond as expected, the deciduous PFTs allocate C but do not allocate N.   
    3538 
    3639== ISSUES == 
     
    4548 
    4649=== 06.01.2016 === 
    47 - [NOT solved] the code still makes use of biomass and circ_class_biomass. Both were kept because in th einitial implementation the labile and reserve pool were not defined at the circumference level. While merging phenology I found my myself working on code that distributed the reserves over the circumference classes. If this is consistently done throughout stomate there is no reason to keep biomass (and ind). This would also overcome the need to sync biomass vs circ_class_biomass and ind vs circ_class_ind. 
     50- [NOT solved] the code still makes use of biomass and circ_class_biomass. Both were kept because in the initial implementation the labile and reserve pool were not defined at the circumference level. While merging phenology I found my myself working on code that distributed the reserves over the circumference classes. If this is consistently done throughout stomate there is no reason to keep biomass (and ind). This would also overcome the need to sync biomass vs circ_class_biomass and ind vs circ_class_ind. 
    4851- [NOT solved] the Nitrogen version of the code makes use of Nsupport when impose_cn is TRUE. The function of the variable seems identical to atm_to_bm (which replaces co2_to_bm and n_to_bm) so Nsupport is no longer used. Confirm whether this is acceptable. 
    49 - [NOT solved] The code for the dynamic N-cycle seems to be incomplete (the if-loop only accounts for one case for other cases variables may become undefined). This section was marked with +++CHEC+++. 
     52- [solved] The code for the dynamic N-cycle seems to be incomplete (the if-loop only accounts for one case for other cases variables may become undefined). This section was marked with +++CHECK+++. 
    5053 
    5154=== 12.01.2016 === 
     
    5356 
    5457=== 27.01.2016 === 
    55 - [NOT solved] it needs to be tested whether stomate_allocation.f90 correctly synchronizes biomass and circ_class_biomass for nitrogen. The code crashes before N gets allocated so it can not be tested for the moment. 
    56 - [NOT solved] lai is an input variable in diffuco_trans_co2 in ORCHIDEE-CN but is calculated in sechiba in ORCHIDEE-CAN. For the moment no lai is passed to diffuco and so it model crashes on photosynthesis. 
     58- [solved] it needs to be tested whether stomate_allocation.f90 correctly synchronizes biomass and circ_class_biomass for nitrogen. The code crashes before N gets allocated so it can not be tested for the moment. 
     59- [solved] lai is an input variable in diffuco_trans_co2 in ORCHIDEE-CN but is calculated in sechiba in ORCHIDEE-CAN. For the moment no lai is passed to diffuco and so the model crashes on photosynthesis. 
    5760- [NOT solved] in the first time step lai is prescribed (8, 4, ...), lai is not capped in ORCHIDEE-CAN so this should be checked and removed. 
    5861 
     62=== 03.02.2016 === 
     63- [NOT solved] No nitrogen allocation for deciduous trees 
     64- [NOT solved] Added a patch for allow_initpheno in stomate_phenology to make the model work with turnover. 
    5965 
    6066[[BR]]