Changes between Version 4 and Version 5 of FMCleanUp

Timestamp:

2012-09-17T11:04:12+02:00 (12 years ago)

Author:

tdgroote

Comment:

--

FMCleanUp

@@ -8 +8 @@
 2. ...
 
+
+----
+FROM TDG
+
+1. stomate_forestry.f90 line 1292 the lai_max_calc for SRC is only called if lai_max_calc < 2. At the start of the plantation, the lai was higher than 2, from the spinup (maybe because I didn't use the last year of my spinup?) and therefore lai_max_calc was not calculated as it should in the first year of SRC.[[BR]]
+I solved it by moving it out of:[[BR]]
+{{{
+IF ( lai_max_calc(i,j) .LT. 2.) THEN ... ENDIF
+}}}
+and rewriting it as:[[BR]]
+{{{
+IF (clearfirst .AND. forest_managed(i,j) == 4) lai_max_calc(i,j)=min(real(0+1)**2/4.,1.)*lai_max(j)
+}}}
+
+
+2. In stomate.f90 line 705, forest_managed16 is read and passed to stomateLPJ, readstart ..., but not to stomate_forestry.[[BR]]
+In stomate_forestry.f90 line 2404, forest_managed16 is read again and used passed around a lot.[[BR]]
+In stomate_constants.f90 line 567, the forest management flag is read again, but this time in a global variable. This variable is only used once in stomate_data.[[BR]]
+Maybe it's better to read the flag only once in a global variable, so you don't waste cpu on I/O operations and you don't need to pass it around that much.
+
+3. In stomate_forestry.f90 line 2477-2485, the initial biomass after clearcut is set. Why does it add heartwood and doesn't it just use the values specified in stomate_data? [[BR]]
+I added the following line to overwrite this for SRC, because I start my plantation with cuttings, not saplings, and they don't contain heartwood.[[BR]]
+{{{
+IF ((j==6).AND.(forest_managed(i,j)==4)) THEN
+  bm_init(:) = bm_sapl(j,:)
+ENDIF
+}}}