Changeset 8179 for branches/2016/dev_r6859_LIM3_meltponds/NEMOGCM/NEMO/LIM_SRC_3/limmp.F90

Timestamp:

2017-06-15T12:01:17+02:00 (7 years ago)

Author:

vancop

Message:

Replace total snow flux by snow meltwater flux

File:

• branches/2016/dev_r6859_LIM3_meltponds/NEMOGCM/NEMO/LIM_SRC_3/limmp.F90 (modified) (6 diffs)

branches/2016/dev_r6859_LIM3_meltponds/NEMOGCM/NEMO/LIM_SRC_3/limmp.F90

@@ -129 +129 @@
       ENDIF
 
+      IF ( ln_pnd .AND. ( nn_pnd_scheme == 0 ) .AND. ( ln_pnd_fw ) ) THEN
+         WRITE(numout,*) ' Prescribed melt ponds do not conserve fresh water mass, hence ln_pnd_fw must be set to false ' 
+         ln_pnd_fw     = .FALSE.
+         IF(lwp) THEN                     ! control print
+            WRITE(numout,*) '    Active melt ponds freshwater coupling                       ln_pnd_fw     = ', ln_pnd_fw
+         ENDIF
+      ENDIF
+
       IF ( ln_pnd .AND. ( nn_pnd_scheme == 2 ) .AND. ( jpl == 1 ) ) THEN
          WRITE(numout,*) ' Topographic melt ponds are incompatible with jpl = 1 '
@@ -280 +288 @@
         !------------------------------------------------------------------
  
-        zwfx_mlw(:,:) = MAX( wfx_sum(:,:) + wfx_snw(:,:), 0._wp )        ! available meltwater for melt ponding
+        zwfx_mlw(:,:) = MAX( wfx_sum(:,:) + wfx_snw_sum(:,:), 0._wp )        ! available meltwater for melt ponding
 
                 ! NB: zwfx_mlw can be slightly negative for very small values (why?)
@@ -289 +297 @@
                 ! if we understand and remove why wfx_sum or wfx_snw could be
                 ! negative, then, we can remove the MAX
+                ! NB: I now changed to wfx_snw_sum, this may fix the problem. 
+                ! We should check
  
         zrfrac(:,:,:) = zrmin + ( zrmax - zrmin ) * a_i(:,:,:)  
@@ -352 +362 @@
  
                 a_ip_frac(ji,jj,jl) = MIN( 1._wp , SQRT( v_ip(ji,jj,jl) * z1_zpnd_aspect / a_i(ji,jj,jl) ) )
+                   !NB: the SQRT has been a recurring source of crash when v_ip or a_i tuns to be even only slightly negative
  
                 h_ip(ji,jj,jl)      = zpnd_aspect * a_ip_frac(ji,jj,jl)
@@ -374 +385 @@
         IF ( ln_pnd_fw ) THEN
  
-            wfx_snw(:,:) = wfx_snw(:,:) *  ( 1. - zrmin - ( zrmax - zrmin ) * at_i(:,:) )
- 
-            wfx_sum(:,:) = wfx_sum(:,:) *  ( 1. - zrmin - ( zrmax - zrmin ) * at_i(:,:) )
- 
+            wfx_snw_sum(:,:) = wfx_snw_sum(:,:) *  ( 1. - zrmin - ( zrmax - zrmin ) * at_i(:,:) ) 
+
+            wfx_sum(:,:)     = wfx_sum(:,:) * ( 1. - zrmin - ( zrmax - zrmin ) * at_i(:,:) )
+
         ENDIF
 
@@ -496 +507 @@
        kcells(:)   = 0
 
-       zvolp(:,:) = wfx_sum(:,:) + wfx_snw(:,:) + vt_ip(:,:) ! Total available melt water, to be distributed as melt ponds
+       zvolp(:,:) = wfx_sum(:,:) + wfx_snw_sum(:,:) + vt_ip(:,:) ! Total available melt water, to be distributed as melt ponds
        zTsfcn(:,:,:) = zTsfcn(:,:,:) - rt0                   ! Convert in Celsius