Changeset 8427 for branches/UKMO/dev_r5518_GO6_package/NEMOGCM/NEMO/TOP_SRC/trcrst.F90

Timestamp:

2017-08-09T12:13:16+02:00 (7 years ago)

Author:

timgraham

Message:

GMED ticket 341. Fixes found through use of preset NaNs? to make the code more robust.

File:

• branches/UKMO/dev_r5518_GO6_package/NEMOGCM/NEMO/TOP_SRC/trcrst.F90 (modified) (3 diffs)

branches/UKMO/dev_r5518_GO6_package/NEMOGCM/NEMO/TOP_SRC/trcrst.F90

@@ -745 +745 @@
       !!---------------------------------------------------------------------
       INTEGER  :: jk, jn
+      CHARACTER (LEN=18) :: text_zmean
       REAL(wp) :: ztraf, zmin, zmax, zmean, areasf
       REAL(wp), DIMENSION(jpi,jpj) :: zvol
@@ -750 +751 @@
 
       IF( lwp )  WRITE(numout,*) 'STAT- ', names
-      !
+      
+      ! fse3t_a will be undefined at the start of a run, but this routine
+      ! may be called at any stage! Hence we MUST make sure it is 
+      ! initialised to zero when allocated to enable us to test for 
+      ! zero content here and avoid potentially dangerous and non-portable 
+      ! operations (e.g. divide by zero, global sums of junk values etc.)   
       zvol(:,:) = e1e2t(:,:) * fse3t_a(:,:,1) * tmask(:,:,1)
       ztraf = glob_sum( dgtr(:,:) * zvol(:,:) )
@@ -761 +767 @@
          CALL mpp_max( zmax )      ! max over the global domain
       END IF
-      zmean  = ztraf / areasf
-      IF(lwp) WRITE(numout,9002) TRIM( names ), zmean, zmin, zmax
-      !
-      IF(lwp) WRITE(numout,*)
-9002  FORMAT(' tracer name :',a10,'    mean :',e18.10,'    min :',e18.10, &
+
+      text_zmean = "N/A"
+      ! Avoid divide by zero. areasf must be positive.
+      IF  (areasf > 0.0) THEN 
+         zmean = ztraf / areasf
+         WRITE(text_zmean,'(e18.10)') zmean
+      ENDIF
+
+      IF(lwp) WRITE(numout,9002) TRIM( names ), text_zmean, zmin, zmax
+
+  9002  FORMAT(' tracer name :',A,'    mean :',A,'    min :',e18.10, &
       &      '    max :',e18.10 )
       !