Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#1261 closed Bug (fixed)

Incidental failure of the tests of the tangent-linear and adjoint versions of the vertical-tracer-mixing subroutines

Reported by: sam Owned by: nemo
Priority: low Milestone:
Component: TAM Version: release-3.4
Severity: Keywords: TAM
Cc: Branch review:
MP ready?: Task progress:

Description

The results of the tests of the tangent-linear and adjoint versions of subroutines 'tra_zdf_exp' and 'tra_zdf_imp' have been found to switch between success and failure when a seemingly-unrelated model option is toggled (compiling with and without 'key_mpp_mpi').

Examination of the test subroutines 'tra_zdf_exp_adj_tst' and 'tra_zdf_imp_adj_tst' revealed that the array 'r2dtra' remains undefined prior to being used in the tangent-linear and adjoint versions of the subroutines that compute the vertical tracer mixing. The test subroutines are independently implemented for the optional time stepping schemes (split-explicit or implicit), and the tangent-linear and adjoint versions of the specific implementations are called directly by the tests. In contrast, as part of the regular time stepping of the tangent-linear or adjoint model, the selected implementation is called via subroutine 'tra_zdf_tan' or 'tra_zdf_adj', which both define the array 'r2dtra', and so this bug does not occur during the regular tangent-linear or adjoint time step.

Commit History (1)

ChangesetAuthorTimeChangeLog
4568pabouttier2014-03-25T11:56:08+01:00

Define r2dtra in trazdf_tam adjoint test, see Ticket #1261

Change History (5)

comment:1 Changed 7 years ago by pabouttier

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 5 years ago by nicolasmartin

  • Keywords TAM added

comment:3 Changed 5 years ago by nicolasmartin

  • Keywords nemo_v3_4* added

comment:4 Changed 3 years ago by nemo

  • Keywords release-3.4* added; nemo_v3_4* removed

comment:5 Changed 3 years ago by nemo

  • Keywords release-3.4* removed
Note: See TracTickets for help on using tickets.