New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1276 (Wrong adjoint computation in ssh_wzv_adj) – NEMO

Opened 10 years ago

Closed 10 years ago

Last modified 2 years ago

#1276 closed Bug (fixed)

Wrong adjoint computation in ssh_wzv_adj

Reported by: pabouttier Owned by: nemo
Priority: low Milestone:
Component: TAM Version: v3.4
Severity: Keywords: TAM v3.4
Cc:

Description

         sshb_ad(:,:) = sshb_ad(:,:) + ssha_ad(:,:)* tmask(:,:,1)
         emp_ad( :,:) = emp_ad(:,:)  - z2dt * z1_rau0 * ssha_ad(:,:) * tmask(:,:,1)
         emp_b_ad( :,:) = emp_b_ad(:,:) - z2dt * z1_rau0 * ssha_ad(:,:) * tmask(:,:,1)
         zhdivad(:,:) = zhdivad(:,:) - z2dt * tmask(:,:,1) * ssha_ad(:,:)
         ssha_ad(:,:) = 0.0_wp

must be replaced by :

         ssha_ad( :,:) = ssha_ad( :,:) * tmask(:,:,1)
         sshb_ad( :,:) = sshb_ad( :,:) + ssha_ad(:,:)
         ssha_ad( :,:) = ssha_ad( :,:) * z2dt
         zhdivad( :,:) = zhdivad( :,:) - ssha_ad(:,:)
         ssha_ad( :,:) = ssha_ad( :,:) * z1_rau0 
         emp_ad(  :,:) = emp_ad(  :,:) - ssha_ad(:,:)
         emp_b_ad(:,:) = emp_b_ad(:,:) - ssha_ad(:,:)
         ssha_ad(:,:) = 0.0_wp

Commit History (1)

ChangesetAuthorTimeChangeLog
4582pabouttier2014-03-26T10:30:54+01:00

Correct a wrong adjoint computation in ssh_wzv_adj, see Ticket #1276

Change History (6)

comment:1 Changed 10 years ago by pabouttier

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 8 years ago by nicolasmartin

  • Keywords TAM added

comment:3 Changed 8 years ago by nicolasmartin

  • Keywords nemo_v3_4* added

comment:4 Changed 6 years ago by nemo

  • Keywords release-3.4* added; nemo_v3_4* removed

comment:5 Changed 6 years ago by nemo

  • Keywords release-3.4* removed

comment:6 Changed 2 years ago by nemo

  • Keywords v3.4 added
Note: See TracTickets for help on using tickets.