New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1278 (Wrong loops in lbcnfc_tam) – NEMO

Opened 10 years ago

Closed 10 years ago

Last modified 2 years ago

#1278 closed Bug (fixed)

Wrong loops in lbcnfc_tam

Reported by: pabouttier Owned by: nemo
Priority: low Milestone:
Component: TAM Version: v3.4
Severity: Keywords: TAM v3.4
Cc:

Description

In many loops, following code : 

pt3d(ijt,ijpjm1,jk) = pt3d(ijt,ijpjm1,jk) + psgn * pt3d(ji,ijpjm1,jk)
pt3d(ji ,ijpjm1,jk) = 0.0_wp

has to be replaced by : 

ztmp = psgn * pt3d(ji,ijpjm1,jk)
pt3d(ji ,ijpjm1,jk) = 0.0_wp
pt3d(ijt,ijpjm1,jk) = pt3d(ijt,ijpjm1,jk) + ztmp

where ztmp is a temporary real.

Commit History (1)

ChangesetAuthorTimeChangeLog
4584pabouttier2014-03-26T10:48:29+01:00

Fix wrong loop in lbcnfd_tam, see Ticket #1278. Add calls to mpp_sum in adjoint tests

Change History (6)

comment:1 Changed 10 years ago by pabouttier

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 8 years ago by nicolasmartin

  • Keywords TAM added

comment:3 Changed 8 years ago by nicolasmartin

  • Keywords nemo_v3_4* added

comment:4 Changed 6 years ago by nemo

  • Keywords release-3.4* added; nemo_v3_4* removed

comment:5 Changed 6 years ago by nemo

  • Keywords release-3.4* removed

comment:6 Changed 2 years ago by nemo

  • Keywords v3.4 added
Note: See TracTickets for help on using tickets.