New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1343 (Allow coupling fieldnames to be arbitrary length) – NEMO

Opened 10 years ago

Closed 9 years ago

Last modified 2 years ago

#1343 closed Bug (invalid)

Allow coupling fieldnames to be arbitrary length

Reported by: timgraham Owned by: timgraham
Priority: low Milestone:
Component: OCE Version: v3.6
Severity: Keywords: OASIS OPA coupling v3.6
Cc:

Description

From NEMO 3.4 onwards this line in OPA_SRC/cpl_oasis3.F90
WRITE(zclname,'( a7, i1)') ssnd(ji)%clname,jc
assumes that all 'multicategory' coupling fields have a name of length 7 characters. This line produces a filename consisting of the field name and the category number. If the field name has fewer than 7 characters then this causes problems with the fields not being transferred.

The following fix is proposed. The above line will be replaced with:

WRITE(cl_jc,'(i1)') jc 
zclname = trim(adjustl(ssnd(ji)%clname)) // cl_jc

where jc is the category number (already exists) and cl_jc is the category number expressed as a string.

This code has been tested in a local branch. If there are no objections then I will implement this change in NEMO 3.4 stable and NEMO 3.6 alpha later this week.

Commit History (0)

(No commits)

Change History (6)

comment:1 Changed 10 years ago by timgraham

  • Owner changed from NEMO team to timgraham
  • Status changed from new to assigned

comment:2 Changed 9 years ago by timgraham

  • Resolution set to invalid
  • Status changed from assigned to closed

This ticket is no longer valid as the code was changed in the 2014 merge.

comment:3 Changed 6 years ago by nemo

  • Keywords OASIS added; oasis3 removed

comment:4 Changed 6 years ago by nemo

  • Keywords release-3.6* added

comment:5 Changed 6 years ago by nemo

  • Keywords release-3.6* removed

comment:6 Changed 2 years ago by nemo

  • Keywords OPA v3.6 added
Note: See TracTickets for help on using tickets.