Opened 6 years ago

Closed 3 years ago

#1346 closed Bug (wontfix)

bug in BDY for multiple boundaries

Reported by: davestorkey Owned by: davestorkey
Priority: low Milestone:
Component: OCE Version: release-3.6
Severity: Keywords:
Cc:

Description

In bdy_dta_init, the initialisation of the bf structure is incorrect if multiple boundary sets (>1) are defined:

jstart = 1
DO ib_bdy = 1, nb_bdy

jend = nb_bdy_fld(ib_bdy)
CALL fld_fill( bf(jstart:jend), blf_i(jstart:jend), cn_dir_array(ib_bdy), 'bdy_dta', &
& 'open boundary conditions', 'nambdy_dta' )
jstart = jend + 1

ENDDO

The jend index is set incorrectly for ib_bdy > 1. The correct formula should be:

jend=jstart-1+nb_bdy_fld(ib_bdy)

Commit History (1)

ChangesetAuthorTimeChangeLog
4673davestorkey2014-06-18T11:44:54+02:00

Fix indexing bug in bdy_dta_init. Ticket #1346.

Change History (2)

comment:1 Changed 6 years ago by davestorkey

Fixed at rev 4673.

I think there is a similar bug in the following lines of bdy_dta (around line 317 of bdydta.F90) :

ELSE

IF (cn_tra(ib_bdy) == 'runoff') then ! runoff condition

jend = nb_bdy_fld(ib_bdy) <<<<<<<<<<<<<<<<<<<
CALL fld_read( kt=kt, kn_fsbc=1, sd=bf(jstart:jend), &

& map=nbmap_ptr(jstart:jend), kt_offset=time_offset )

!

Jerome (or anyone) do you agree?

comment:2 Changed 3 years ago by clevy

  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.