Opened 6 years ago

Closed 2 years ago

Last modified 2 months ago

#1362 closed Bug (fixed)

missing bits in dynzdf_imp_tam

Reported by: avidard Owned by: pabouttier
Priority: low Milestone:
Component: TAM Version: release-3.4
Severity: minor Keywords: TAM
Cc:

Description

There are bits that are commented out in dynzdf_imp_tam if ln_bfrimp is true, these should be put back in the code, otherwize the wrong direct values for avm[uv] will be used

Commit History (2)

ChangesetAuthorTimeChangeLog
13419smueller2020-08-21T13:04:45+02:00

Addition of variable allocations/deallocations and harmonisation of subroutine dyn_zdf_imp_adj with its tangent-linear counterpart (application of the patch attached to ticket #1362)

5150pabouttier2015-03-18T11:04:44+01:00

Adding missing bits in DYN/dynzdf_imp_tam.F90; See Ticket #1362

Attachments (1)

dynzdf_imp_tam.F90.diff (4.8 KB) - added by sam 2 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 6 years ago by clevy

  • Owner changed from NEMO team to pabouttier

comment:2 Changed 6 years ago by bouttier

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 6 years ago by sam

  • Component changed from OPA to OPA_TAM
  • Priority changed from minor to critical
  • Resolution fixed deleted
  • Status changed from closed to reopened

Changeset 5150 introduced two follow-on problems into module 'dynzdf_imp_tam':

1) the activated code assigns values to the temporary variables 'zavmu' and 'zavmv' that currently lack allocation and deallocation;

2) if 'ln_bfrimp' is set to '.true.', the tangent-linear and adjoint subroutines in module 'dynzdf_imp_tam' no longer correspond to each other.

In subroutine 'dyn_zdf_imp_adj' two sections of commented-out code, which correspond to the newly activated sections in 'dyn_zdf_imp_tan', should also be activated (together with appropriate variable declarations, allocations, and deallocations) in order to bring the adjoint code in line with its tangent-linear counterpart. Currently, however, these two sections are in reverse order and should be exchanged with each other.

comment:4 Changed 4 years ago by nicolasmartin

  • Keywords develoments added

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords developments added; develoments removed

comment:6 Changed 4 years ago by nicolasmartin

  • Keywords TAM added

comment:7 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4* added

comment:8 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4 added; developments removed

comment:9 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4 removed

comment:10 Changed 4 years ago by nicolasmartin

  • Milestone TAM deleted

Milestone TAM deleted

comment:11 Changed 3 years ago by nemo

  • Keywords release-3.4* added; nemo_v3_4* removed

comment:12 Changed 3 years ago by nemo

  • Keywords release-3.4* removed

comment:13 Changed 3 years ago by nicolasmartin

  • Priority changed from high to low
  • Severity set to minor

Decision has to be made on this old ticket: if relevant the version of the release must be updated (release-3.6 or trunk for upcoming 4.0), if not close the ticket.

Changed 2 years ago by sam

comment:14 Changed 2 years ago by sam

The follow-on bugs in 'dynzdf_imp_tam.F90' after application of changeset 5150 can be fixed by using the attached diff file 'dynzdf_imp_tam.F90.diff' to patch 'dynzdf_imp_tam.F90'.

comment:15 Changed 2 years ago by nicolasmartin

  • Resolution set to fixed
  • Status changed from reopened to closed

Thanks for sharing your own fix ;-).
Arguably we are not going to commit it to the release version of the code so I close the ticket.

comment:16 Changed 2 months ago by smueller

In 13419:

Addition of variable allocations/deallocations and harmonisation of subroutine dyn_zdf_imp_adj with its tangent-linear counterpart (application of the patch attached to ticket #1362)

Note: See TracTickets for help on using tickets.