New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1607 (out-of-bound references in agrif_lim2_update (lim2_vp case) in trunk and v3_6_STABLE) – NEMO

Opened 9 years ago

Closed 7 years ago

Last modified 2 years ago

#1607 closed Bug (fixed)

out-of-bound references in agrif_lim2_update (lim2_vp case) in trunk and v3_6_STABLE

Reported by: mscheinert Owned by: nemo
Priority: normal Milestone: 2015 release-3.6
Component: AGRIF Version: v3.6
Severity: Keywords: LIM* v3.6
Cc:

Description

In subroutine update_v_ice() of module agrif_lim2_update (with key_lim2_vp) there is an out-of-bound reference in e1f which can lead to NaN entries causing a MPI dead-lock or a crash.

179	         DO jj=j1,j2 
180	            DO ji=i1,i2 
181	               v_ice(ji,jj) = tabres(ji,jj) / (e1f(ji-1,jj-1)) 
182	               v_ice(ji,jj) = v_ice(ji,jj) * tmu(ji,jj) 
183	            END DO 
184	         END DO

Analogue to the other do loop in the same routine, I suggest to use MAX() function, too:

179	         DO jj=MAX(j1,2),j2
180	            DO ji=MAX(i1,2),i2

Commit History (1)

ChangesetAuthorTimeChangeLog
7641clem2017-02-03T16:19:34+01:00

bug fix for AGRIF+LIM2-VP, see ticket #1607

Change History (12)

comment:1 Changed 8 years ago by jcastill

  • Version changed from trunk to v3.6

comment:2 Changed 8 years ago by jcastill

  • Milestone set to 2015 nemo_v3_6_STABLE

comment:3 Changed 8 years ago by nicolasmartin

  • Keywords agrif removed

comment:4 Changed 8 years ago by nicolasmartin

  • Keywords LIM2 added; lim2 removed

comment:5 Changed 8 years ago by nicolasmartin

  • Keywords nemo_v3_6* added

comment:6 Changed 8 years ago by nicolasmartin

  • Keywords lim2_vp removed

comment:7 Changed 7 years ago by fschwarzkopf

This is mandatory for AGRIF with LIM2-VP!

comment:8 Changed 7 years ago by clem

  • Resolution set to fixed
  • Status changed from new to closed

fixed at r7641

comment:9 Changed 6 years ago by nemo

  • Keywords release-3.6* added; nemo_v3_6* removed

comment:10 Changed 6 years ago by nemo

  • Keywords LIM* added; LIM2 removed

comment:11 Changed 6 years ago by nemo

  • Keywords release-3.6* removed

comment:12 Changed 2 years ago by nemo

  • Keywords v3.6 added
Note: See TracTickets for help on using tickets.