Opened 9 years ago
Closed 5 years ago
#1636 closed Bug (fixed)
"Now" bottom tracer gradients in later diffusion with zps ?
| Reported by: | jchanut | Owned by: | gm |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | TRA | Version: | trunk |
| Severity: | minor | Keywords: | TRA diffusion |
| Cc: | gm |
Description
The actual step is pretty hard to follow.
It seems that, at least with split explicit free surface, bottom tracer gradients at "before" step (call to zpshde at the begining of the step), have been overwritten by "now" values at the time of performing lateral diffusion.
Commit History (1)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 11416 | jchanut | 2019-08-07T12:11:36+02:00 | #1636: remove overwriting of before tracer gradients over partial cells by now values. Should make tracer diffusion more robust. Now density gradients are now computed in hpg_zps only. |
Change History (8)
comment:1 Changed 9 years ago by gm
comment:2 Changed 8 years ago by nicolasmartin
- Keywords TRA added; zps removed
comment:3 Changed 7 years ago by clevy
- Owner changed from nemo to gm
comment:4 Changed 7 years ago by clevy
- Cc gm added
- Status changed from new to assigned
comment:5 Changed 7 years ago by gm
- Priority changed from major to minor
- Version changed from v3.6 to trunk
This issue has to be checked (and solved if necessary) for the trunk version.
comment:6 Changed 5 years ago by jchanut
- Component changed from OCE to TRA
- Severity set to minor
comment:7 Changed 5 years ago by jchanut
In 11416:
comment:8 Changed 5 years ago by jchanut
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.
I agree .
This concern only the split explicit free surface, as in filtered and explicit cases, tra_ldf is called before the call to zps_hde and the subsequent call to den_hpg.
This error is in both the trunk and the v3.6_stable