Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#1677 closed Bug (fixed)

Bug on passive tracers damping

Reported by: cetlod Owned by: nemo
Priority: low Milestone: 2015 release-3.6
Component: TOP Version: release-3.6
Severity: Keywords: 2015
Cc: aumont

Description

The is a minor bug of passive tracers damping.
The multiplicative factor of passive tracers values read in namelist_top are not taken into account properly.
The bugs are both in trunk & 3.6 stable

Commit History (4)

ChangesetAuthorTimeChangeLog
6701lovato2016-06-13T17:29:32+02:00

#1677 - trunk: Update code for passive tracers data input and restoring

6688lovato2016-06-13T14:50:45+02:00

#1677 - v3.6_STABLE: Update code for passive tracers data input and restoring

6309cetlod2016-02-12T12:47:24+01:00

trunk : bugfix on passive tracers damping, see ticket #1677

6308cetlod2016-02-12T12:32:54+01:00

3.6 stable : bugfix on passive tracers damping, see ticket #1677

Change History (5)

comment:1 Changed 4 years ago by cetlod

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 4 years ago by lovato

After the analysis of trc_dmp and trc_dta at the revision 5550,
it turned out that the problem with the tracer damping was not due to an improper use of multiplicative factor of passive tracers, but it was related to the wrong assumption in trc_dta that the now field of data structure (e.g. sf_dta%fnow) passed by fldread are refreshed at every timestep even if not interpolated in time.

DIC, for example, is an annual field and fldread read it only once in a year-long run when kt=nit000 (in reality twice at nit000, one in trc_ini and one trc_dmp).

So when using trc_dta (at r5550) for passive tracer damping, from the timestep 2 on the scaling factor and the vertical interpolation (for sco or zps) were applied to sf_dta%fnow at every time step producing a wrong/weird damping since the reference field was repeatedly scale and interpolated.

These routines were modified to solve this issue (see r6688 on v3_6_STABLE), by also preserving the subroutines argument passing of r5550 to cope with previous releases of V3.6_stable.
However, trc_dta has to be revised in the update of TOP interface for the trunk development (see WP2016).

Note that, a missing call to trc_dmp_alloc has also to be added in trc_dmp_init.

comment:3 Changed 4 years ago by nicolasmartin

  • Keywords 2015 nemo_v3_6* added

comment:4 Changed 3 years ago by nemo

  • Keywords release-3.6* added; nemo_v3_6* removed

comment:5 Changed 3 years ago by nemo

  • Keywords release-3.6* removed
Note: See TracTickets for help on using tickets.