Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#1682 closed Bug (fixed)

grid cell thicknesses written to diagnostics at wrong time level

Reported by: davestorkey Owned by: nemo
Priority: low Milestone: 2015 release-3.6
Component: OCE Version: release-3.6
Severity: Keywords: 2015
Cc:

Description

The time-varying grid cell thicknesses (e3t, e3u etc) are sent to XIOS using iom_put calls in dom_vvl_sf_swp after the time-swapping has been done. This means that they are valid on the next time level compared to all the other diagnostics. So for example the toce_e3t diagnostic defined in the field_def.xml file multiplies toce and e3t which are valid at different times.

I propose moving the iom_put calls in dom_vvl_sf_swp to before the time swapping.

Commit History (3)

ChangesetAuthorTimeChangeLog
6351cetlod2016-02-24T19:50:11+01:00

trunk: move the output of scale factor before time swapping and output some variables needs for offline, see ticket #1682

6349davestorkey2016-02-24T14:18:49+01:00

Temporary fix for bug in NEMO whereby grid cell thicknesses were written to diagnostics at wrong time level. NB. This has now been fixed at the latest version of 3.6_stable (ticket #1682). Only putting the fix in this branch in order to rerun some old experiments.

6348cetlod2016-02-24T11:44:07+01:00

bugfix: move the output of scale factor before time swapping and output some variables needs for offline, see ticket #1682

Change History (7)

comment:1 Changed 5 years ago by cetlod

I agree and after discussion with Gurvan, we propose to move the iom_put from dom_vvl_sf_swp to diawri.f90, if no objection.

comment:2 Changed 5 years ago by davestorkey

Fine with me.

comment:3 Changed 5 years ago by cetlod

Done in v3.6 stable together with the outputs of additional diagnostics needed for offline in vvl, see changeset:6348

Must be done also in the trunk

comment:4 Changed 5 years ago by cetlod

  • Resolution set to fixed
  • Status changed from new to closed

Done in trunk, see changeset:6351

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords 2015 nemo_v3_6* added

comment:6 Changed 3 years ago by nemo

  • Keywords release-3.6* added; nemo_v3_6* removed

comment:7 Changed 3 years ago by nemo

  • Keywords release-3.6* removed
Note: See TracTickets for help on using tickets.