New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1691 (Missing call to ldf_dyn in step (only relevant to time-varying eddy viscosity cases)) – NEMO

Opened 8 years ago

Closed 8 years ago

#1691 closed Bug (fixed)

Missing call to ldf_dyn in step (only relevant to time-varying eddy viscosity cases)

Reported by: acc Owned by: acc
Priority: low Milestone: 2016 WP
Component: OCE Version: trunk
Severity: Keywords:
Cc:

Description

Description

There is no call to ldf_dyn in step.F90 even if the viscosity coefficient is expected to vary in time (l_ldfdyn_time = .true.) .Currently, this is only relevant if nn_ahm_ijk_t=31 (momentum mixing coefficient proportional to velocity) which is a recent (untested) addition. However, this is a bug which should be fixed before the creation of branches for 2016 developments that may require the same mechanism (e.g. the re-implementation of Smagorinsky).

Analysis

All that is required is an additional line in step.F90

Recommendation

Add:

      IF( l_ldfdyn_time                    )   CALL ldf_dyn( kstp )       ! eddy viscosity coeff.

immediately below call to ldf_tra

Commit History (1)

ChangesetAuthorTimeChangeLog
6381acc2016-03-10T15:12:49+01:00

Trunk only. #1691 Add missing call to ldf_dyn in step.F90 needed for time-varying eddy viscosity coefficients

Change History (1)

comment:1 Changed 8 years ago by acc

  • Resolution set to fixed
  • Status changed from new to closed

Line added at revision changeset:6381

Note: See TracTickets for help on using tickets.