Opened 17 months ago

Closed 3 months ago

#1724 closed Bug (fixed)

makenemo fails to delete key in some case

Reported by: Olivier Marti Owned by: nemo
Priority: minor Milestone:
Component: CFG_TOOLS Version: nemo_v3_6_STABLE
Keywords: Cc:

Description

Context

Building NEMO

Analysis

I run the command
./makenemo -m ${FCM_ARCH} -n ORCA1_LIM3_PISCES -d "OPA_SRC LIM_SRC_3 NST_SRC TOP_SRC" -j16 add_key "key_oasis3 key_top key_pisces key_diahth zdftmx_new" del_key "key_mpp_rep key_nosignedzero zdftmx"

What I get as cpp keys is :
bld::tool::fppkeys key_trabbl key_lim3 key_vvl key_dynspg_ts key_diaeiv key_ldfslp key_traldf_c2d key_traldf_eiv key_dynldf_c3d key_zdfddm key_ key_mpp_mpi key_zdftke key_iomput key_top key_pisces key_oasis3 key_diahth _new

makenemo adds zdftmx_new, and then suppress part of it when deleting zdftmx.

Fix

In TOOLS/COMPILE/Fdel_keys.sh, on should add some words delimiters in the sed command at line 69 :
sed -e "s/ ${i}[ ,$]/ /"
Whitespaces are importants !!

Commit History (4)

ChangesetAuthorTimeChangeLog
8254nicolasmartin2017-06-29T17:29:29+02:00

Updates for operational diagnostics:
25h mean diagnostics - bottom temperature (and insitu temp)
Operational foam diagnostics - diaopfoam and DIU routines added.

Code review status: PENDING

8252nicolasmartin2017-06-29T17:20:03+02:00

#1724 Modify sed command for deleting key in order to match word (use \b)

8218lovato2017-06-26T16:26:34+02:00

trunk: bugfix for ticket #1724

8217lovato2017-06-26T16:26:21+02:00

3.6 stable: bugfix for ticket #1724

Change History (4)

comment:1 Changed 3 months ago by Tomas Lovato

  • Resolution set to fixed
  • Status changed from new to closed

The proposed fix was implemented v3.6_stable ar r8217
and in the trunk at r8218.

In addition the key_tide option was removed from SETTE test of trunk
as it was removed from the code within 2016 simplification activity.

comment:2 Changed 3 months ago by Nicolas MARTIN

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:3 Changed 3 months ago by Nicolas MARTIN

The suggested fix is not good as it fails to delete the final key, probably $ is not placed in the good position and should be outside brackets to represent the end of the line.

comment:4 Changed 3 months ago by Nicolas MARTIN

  • Resolution set to fixed
  • Status changed from reopened to closed

New fix with regexp \b in sed command to match word, commit r8252 for 3.6 and r8254 for trunk

Note: See TracTickets for help on using tickets.