Opened 4 years ago

Closed 2 years ago

Last modified 11 months ago

#1738 closed Bug (fixed)

Fixed selection of the surface boundary condition in module 'sbcmod_tam'

Reported by: sam Owned by:
Priority: low Milestone:
Component: TAM Version: release-3.4
Severity: minor Keywords: TAM
Cc:

Description (last modified by nicolasmartin)

Context

The selection of the formulation of the surface boundary condition (SBC) in subroutines 'sbc_tan' and 'sbc_adj' appears to be fixed, irrespective of the variant of SBC selected in namelist 'namsbc'.

Analysis

Module variable 'nsbc' of module 'sbcmod_tam' remains unassigned in subroutine 'sbc_init_tam'. In test runs using the current version of module 'sbcmod_tam', the value of 'nsbc' was found to be zero (it remains unclear whether a default value of zero for 'nsbc' is ensured by the compiler or not), which resulted in the fixed selection of the SBC formulation of the GYRE configuration.

Fix

In module 'sbcmod_tam', the variable 'nsbc' should be explicitly initialised, and the determination of the value for 'nsbc' should be similar to that of the value for 'nsbc' in subroutine 'sbc_init' of module 'sbcmod'.

Commit History (1)

ChangesetAuthorTimeChangeLog
11806smueller2019-10-25T17:43:44+02:00

Enabling of the selection of the flux formulation as surface boundary condition (ln_flx set to .TRUE. in namelist namsbc) and elimination of the use of an unassigned variable (variable nsbc of module sbcmod_tam) in NEMOTAM (application of the patch attached to ticket #1738)

Attachments (1)

sbcmod_tam.F90.diff (760 bytes) - added by sam 2 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 4 years ago by nicolasmartin

  • Keywords TAM added

comment:2 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4* added

comment:3 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4 added

comment:4 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_4 removed

comment:5 Changed 3 years ago by nicolasmartin

  • Description modified (diff)
  • Owner nemo deleted
  • Status changed from new to assigned

comment:6 Changed 3 years ago by nicolasmartin

  • Status changed from assigned to new

comment:7 Changed 3 years ago by nemo

  • Keywords release-3.4* added; nemo_v3_4* removed

comment:8 Changed 3 years ago by nemo

  • Keywords release-3.4* removed

comment:9 Changed 3 years ago by nicolasmartin

  • Severity set to minor

The 3.4 release is no longer supported: if relevant the version at stake must be updated (release-3.6 or trunk for upcoming 4.0), if not close the ticket.

Changed 2 years ago by sam

comment:10 Changed 2 years ago by sam

The unassigned-variable bug described in this ticket can be fixed by using the attached diff file 'sbcmod_tam.F90.diff' to patch 'sbcmod_tam.F90'. This patch enables the selection of the flux SBC formulation as an alternative to the GYRE SBC formulation.

comment:11 Changed 2 years ago by nicolasmartin

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for sharing your own fix .
Arguably we are not going to commit it to the release version of the code so I close the ticket.

comment:12 Changed 11 months ago by smueller

In 11806:

Enabling of the selection of the flux formulation as surface boundary condition (ln_flx set to .TRUE. in namelist namsbc) and elimination of the use of an unassigned variable (variable nsbc of module sbcmod_tam) in NEMOTAM (application of the patch attached to ticket #1738)

Note: See TracTickets for help on using tickets.