#1766 closed Bug (fixed)
Bugs in sbc_cpl
| Reported by: | timgraham | Owned by: | nemo |
|---|---|---|---|
| Priority: | normal | Milestone: | 2015 release-3.6 |
| Component: | OCE | Version: | v3.6 |
| Severity: | Keywords: | OPA v3.6 | |
| Cc: | clem, frrh |
Description
Context
Bugs have been introduced into nemo_v3_6_STABLE from revision 6204 to 6721. I've marked this as major as at least one of these prevents us running our coupled model with CICE at this revision.
...
Analysis
Bug 1 (causes code to crash) :
The code changes can be viewed here:
Line 1504 of the original version of the file has been deleted:
ztmp(:,:) = p_frld(:,:) * zsprecip(:,:) * lfus
The variable ztmp is used in the calculation of zqns_tot (line 1564-8 of the original file). This is a very bad use of a temporary variable name so perhaps we should look for a better solution to this.
Bug 2:
hflx_snow_cea is now only output when LIM3 is used as it is wrapped in a #ifdef key_lim3 statement. Further the calculation of this variable has changed so is the new version only correct for LIM3?
...
Fix
The first bug should be fixed by reinstating the line nearer to where it is used in the code
The 2nd bug should be corrected by either moving the iom_put call outside the #ifdef statement or if the calculation is model dependent then reinstate the old calculation for use with CICE/LIM2.
...
Commit History (2)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 6920 | malcolmroberts | 2016-09-06T18:12:25+02:00 | Added fix from UKMO/dev_r5518_GO6_package@6912 to temporarily fix bug in coupling in ticket #1766 |
| 6912 | timgraham | 2016-09-06T12:42:26+02:00 | Temporary fix in this branch for first bug in ticket #1766 |
Change History (4)
comment:1 Changed 7 years ago by clem
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 6 years ago by nemo
- Keywords release-3.6* added
comment:3 Changed 6 years ago by nemo
- Keywords release-3.6* removed
comment:4 Changed 2 years ago by nemo
- Keywords OPA v3.6 added
