Opened 7 years ago
Closed 7 years ago
#1824 closed Defect (fixed)
trd_trc is sometimes called from tra_adv_tvd even when l_trdtrc is false
Reported by: | timgraham | Owned by: | timgraham |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | OCE | Version: | v3.6 |
Severity: | Keywords: | ||
Cc: |
Description
Context
trd_trc is sometimes called from tra_adv_tvd even when l_trdtrc is false. This causes excessive "You should not have seen this print" messages.
Analysis
The last 2 lines of within the IF statement below should be run at every timestep.
IF( kt == kit000 ) THEN IF(lwp) WRITE(numout,*) IF(lwp) WRITE(numout,*) 'tra_adv_tvd : TVD advection scheme on ', cdtype IF(lwp) WRITE(numout,*) '~~~~~~~~~~~' ! l_trd = .FALSE. l_trans = .FALSE. IF( ( cdtype == 'TRA' .AND. l_trdtra ) .OR. ( cdtype == 'TRC' .AND. l_trdtrc ) ) l_trd = .TRUE. IF( cdtype == 'TRA' .AND. (iom_use("uadv_heattr") .OR. iom_use("vadv_heattr") ) ) l_trans = .TRUE. ENDIF
Fix
Move the 2 lines outside the IF block
Commit History (1)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
7559 | timgraham | 2017-01-16T10:42:54+01:00 | Fix for #1824. Stop erroneous calls to trd_trc from tra_adv_tvd |
Change History (1)
comment:1 Changed 7 years ago by timgraham
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Fixed at r7559