Volume control when using BDY and Time-splitting is not ready for use

[ctlod]

Context

When using CPP key key_bdy + key_dynspg_ts and set ln_vol = .true. in ocean namelist, no volume control is applied along open boundaries.
But no error message arises at running time, so the user can believe that it is activated while it is not.

Analysis

This option has not been implemented yet in combinaison with time-splitting algorithm.
This maybe also the case in the trunk.

Fix

Add a USE module as follows at the beginning of the bodying.F90 module.

USE dynspg_oce, ONLY: lk_dynspg_ts ! Split-explicit free surface flag

Add a control line in bdy_init subroutine close to the line 372:

......
     IF (nb_bdy .gt. 0) THEN 
        '''IF( ln_vol .AND. lk_dynspg_ts ) CALL ctl_stop( 'The volume control through BDY is not yet available in time-splitting ' )''' 
        IF( ln_vol ) THEN                     ! check volume conservation (nn_volctl value)
          IF(lwp) WRITE(numout,*) 'Volume correction applied at open boundaries'
          IF(lwp) WRITE(numout,*)
          SELECT CASE ( nn_volctl )
            CASE( 1 )      ;   IF(lwp) WRITE(numout,*) '      The total volume will be constant'
            CASE( 0 )      ;   IF(lwp) WRITE(numout,*) '      The total volume will vary according to the surface E-P flux'
            CASE DEFAULT   ;   CALL ctl_stop( 'nn_volctl must be 0 or 1' )
          END SELECT
          IF(lwp) WRITE(numout,*)
        ELSE 
          IF(lwp) WRITE(numout,*) 'No volume correction applied at open boundaries'
          IF(lwp) WRITE(numout,*)
        ENDIF
...

[gsamson]

volume control is now working with BDY and time-splitting in trunk and nemo 4.0 release (see ticket #2200), so I modifiy the ticket to "won't fix" for the 3.6 version