New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#1913 (Compilation issue due to typo in diaar5) – NEMO

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#1913 closed Bug (fixed)

Compilation issue due to typo in diaar5

Reported by: nicolasmartin Owned by: nemo
Priority: low Milestone:
Component: OCE Version: v3.6
Severity: minor Keywords:
Cc:

Description (last modified by nemo)

Context


ORCA1_LIM3_PISCES cfg. monitored by trusting tool is down since 27th of May with rev. 8084.
The follow-up of ORCA2_LIM_PISCES cfg. didn't detect an issue.

Analysis


Compilation stops and complains about [ZPE] variable not declared, actually 'pe' is declared and initialised but it is 'zpe' which is used in the loop.

Extract of diaar5.F90
IncludeSource(/branches/2015/nemo_v3_6_STABLE/NEMOGCM/NEMO/OPA_SRC/DIA/diaar5.F90, start=208, end=238, rev=8084, line_numbers=0)?

Fix


Correct the typos

  • NEMO/OPA_SRC/DIA/diaar5.F90

     
    8080      REAL(wp) ::   zaw, zbw, zrw 
    8181      ! 
    8282      REAL(wp), POINTER, DIMENSION(:,:)     :: zarea_ssh , zbotpres       ! 2D workspace  
    83       REAL(wp), POINTER, DIMENSION(:,:)     :: pe                         ! 2D workspace  
     83      REAL(wp), POINTER, DIMENSION(:,:)     :: zpe                         ! 2D workspace  
    8484      REAL(wp), POINTER, DIMENSION(:,:,:)   :: zrhd , zrhop               ! 3D workspace 
    8585      REAL(wp), POINTER, DIMENSION(:,:,:,:) :: ztsn                       ! 4D workspace 
    8686      !!-------------------------------------------------------------------- 
     
    9090      !initialisation 
    9191      IF( kt == nit000 )     CALL dia_ar5_init 
    9292  
    93       CALL wrk_alloc( jpi , jpj              , zarea_ssh , zbotpres, pe ) 
     93      CALL wrk_alloc( jpi , jpj              , zarea_ssh , zbotpres, zpe ) 
    9494      CALL wrk_alloc( jpi , jpj , jpk        , zrhd      , zrhop    ) 
    9595      CALL wrk_alloc( jpi , jpj , jpk , jpts , ztsn                 ) 
    9696 
     
    205205      ! Work done against stratification by vertical mixing 
    206206      ! Exclude points where rn2 is negative as convection kicks in here and 
    207207      ! work is not being done against stratification 
    208          pe(:,:) = 0._wp 
     208         zpe(:,:) = 0._wp 
    209209         IF( lk_zdfddm ) THEN 
    210210            DO jk = 2, jpk 
    211211               DO jj = 1, jpj 
     
    233233               END DO 
    234234            END DO 
    235235         ENDIF 
    236          CALL lbc_lnk(pe, 'T', 1._wp)          
    237          CALL iom_put( 'tnpeo', pe ) 
     236         CALL lbc_lnk(zpe, 'T', 1._wp)          
     237         CALL iom_put( 'tnpeo', zpe ) 
    238238      ENDIF 
    239239      ! 
    240       CALL wrk_dealloc( jpi , jpj              , zarea_ssh , zbotpres, pe ) 
     240      CALL wrk_dealloc( jpi , jpj              , zarea_ssh , zbotpres, zpe ) 
    241241      CALL wrk_dealloc( jpi , jpj , jpk        , zrhd      , zrhop    ) 
    242242      CALL wrk_dealloc( jpi , jpj , jpk , jpts , ztsn                 ) 
    243243      ! 

Commit History (1)

ChangesetAuthorTimeChangeLog
8187nicolasmartin2017-06-19T15:46:10+02:00

Fix for typos in diaar5.F90 [close #1913]

Change History (2)

comment:1 Changed 7 years ago by nicolasmartin

  • Resolution set to fixed
  • Status changed from new to closed

Fix in r8187

comment:2 Changed 6 years ago by nemo

  • Description modified (diff)
  • Severity set to minor
Note: See TracTickets for help on using tickets.