#2000 closed Task (fixed)
ROBUST-14(2017WP) Removal of configuration-dependent hardcoding from closea module in OPA
| Reported by: | davestorkey | Owned by: | davestorkey |
|---|---|---|---|
| Priority: | normal | Milestone: | 2018 release-4.0 |
| Component: | OCE | Version: | trunk |
| Severity: | minor | Keywords: | v4.0 |
| Cc: |
Description
Context
The closea module (recently moved to USR/usrdef_closea.F90) applies special treatment of freshwater fluxes
over closed seas. The areas of the closed seas have up to now been defined by hardcoded (i,j) indices depending on the
configuration (cn_cfg, nn_cfg). I have coded an alternative version where the definitions of the closed seas are read
in as masks from the domain_cfg file.
Implementation plan
See wiki page.
Commit History (2)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 10462 | davestorkey | 2019-01-07T16:39:04+01:00 | Fill in section on closea module in NEMO book. Ticket #2000. |
| 9161 | davestorkey | 2017-12-22T11:31:53+01:00 | Reformulation of closea module. See ticket #2000 https://forge.ipsl.jussieu.fr/nemo/wiki/2017WP/ROBUST-14_Dave_Storkey-Closed_Seas_rewrite |
Change History (10)
comment:1 Changed 6 years ago by davestorkey
comment:2 Changed 6 years ago by davestorkey
In 9161:
comment:3 Changed 6 years ago by davestorkey
- Owner set to davestorkey
- Status changed from new to assigned
Thanks to Gurvan and Clement for pointing out the bugs if ln_read_cfg is false. I'd prefer to put the check on ln_read_cfg inside the dom_clo and clo_bat routines, then l_sbc_clo and l_clo_rnf are always initialised properly.
This change committed at rev 9209. (It definitely doesn't change SETTE results this time).
comment:4 Changed 6 years ago by davestorkey
- Milestone changed from 2017 WP to 2018 release-4.0
This change has now been included in the dev_merge_2017 branch.
Outstanding task is to update the documentation in the NEMO book.
comment:5 Changed 6 years ago by nicolasmartin
- Summary changed from Removal of configuration-dependent hardcoding from closea module in OPA to ROBUST-14(2017WP) Removal of configuration-dependent hardcoding from closea module in OPA
Modification of summary for standardisation
comment:6 Changed 6 years ago by clevy
- Milestone changed from 2018 release-4.0 to 2018 WP
comment:7 Changed 5 years ago by mathiot
- Milestone changed from 2018 WP to 2018 release-4.0
- wp_comment set to This change has been in the trunk during last merge. Outstanding task is to update the documentation in the NEMO book and DOMAINcfg tool README.
comment:8 Changed 5 years ago by davestorkey
In 10462:
comment:9 Changed 5 years ago by davestorkey
- Resolution set to fixed
- Status changed from assigned to closed
Documentation updated. Closing ticket.
comment:10 Changed 2 years ago by nemo
- Keywords v4.0 added
The wiki page for this change is here:
https://forge.ipsl.jussieu.fr/nemo/wiki/2017WP/ROBUST-14_Dave_Storkey-Closed_Seas_rewrite
This contains code design and details of the testing.
Gurvan approved the design of the code and Tim has reviewed the code and testing. The code does not change SETTE results, so I intend to merge the changes into dev_merge_2017.