Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#2002 closed Bug (fixed)

minor bugs in dynnxt and icbtrj (v3.6 and trunk)

Reported by:Gurvan Madec Component: OPA
Version: release-3.6 Severity: minor
Keywords: Cc:
Management
Owned by: Milestone:
Priority: low

Description (last modified by nemo)

In v3.6 stable, trunk and dev_merge_2017, two MINOR bugs :

In dynnxt.F90

context : variable volume (key_vvl in v3.6 ; ln_linssh=F in trunk), and model starts with a euler time-stepping (starting from rest or data assimilation), the swap of e3t, u and v is wrong : swap of now to before time-step instead of after to now.
Only a minor bug as it only concerns the very first Euler time-step of a model run

Fix : lines 233-235, change "_b" by "_n" and "_n" by "_a"

               e3t_b(:,:,jk) = e3t_n(:,:,jk)
               e3u_b(:,:,jk) = e3u_n(:,:,jk)
               e3v_b(:,:,jk) = e3v_n(:,:,jk)

replaced by

               e3t_n(:,:,jk) = e3t_a(:,:,jk)
               e3u_n(:,:,jk) = e3u_a(:,:,jk)
               e3v_n(:,:,jk) = e3v_a(:,:,jk)

In icbtrj.F90

context : in iceberg trajectory output files long name of two variables (ssh_x and ssh_y) has been inverted

Fix : lines 112-113, the last argument of NF90_DEF_VAR function has been inverted:

iret = NF90_DEF_VAR(ntrajid, 'ssh_x', NF90_DOUBLE, n_dim, nsshyid)
iret = NF90_DEF_VAR(ntrajid, 'ssh_y', NF90_DOUBLE, n_dim, nsshxid)

replaced by

iret = NF90_DEF_VAR(ntrajid, 'ssh_x', NF90_DOUBLE, n_dim, nsshxid)
iret = NF90_DEF_VAR(ntrajid, 'ssh_y', NF90_DOUBLE, n_dim, nsshyid)

Commit History (3)

ChangesetAuthorTimeChangeLog
9239gm2018-01-15T18:22:41+01:00

dev_merge_2017: #2002 : sshwzv.F90 same small bug as for dynnxt

9226gm2018-01-15T10:25:23+01:00

dev_merge_2017: #2002 : dynnxt.F90 and icbtrj.F90: minor bug correction

9225gm2018-01-15T10:17:26+01:00

#2002 : v3.6_STABLE : dynnxt.F90 and icbtrj.F90: minor bug correction

Change History (6)

comment:1 Changed 7 months ago by Gurvan Madec

In 9225:

#2002 : v3.6_STABLE : dynnxt.F90 and icbtrj.F90: minor bug correction

Code review status: pending

comment:2 Changed 7 months ago by Gurvan Madec

In 9226:

dev_merge_2017: #2002 : dynnxt.F90 and icbtrj.F90: minor bug correction

Code review status: pending

comment:3 Changed 7 months ago by Gurvan Madec

  • Resolution set to fixed
  • Status changed from new to closed

Fix in v3.6_STABLE —— see rev 9225

Fix in dev_merge_2017 (will be the trunk in February 2018) —— see rev 9226

=⇒>> ticket closed

comment:4 Changed 7 months ago by nemo

  • Description modified (diff)

comment:5 Changed 7 months ago by Gurvan Madec

In 9239:

dev_merge_2017: #2002 : sshwzv.F90 same small bug as for dynnxt

Code review status: pending

comment:6 Changed 7 months ago by Gurvan Madec

associated with dynnxt.F90 issue, there is the same minor bug un sshwzv.F90
The swap in euler 1st time-step case should be : sshn(:,:) = ssha(:,:) , i.e. now ⇐= after (before already = now)
not sshb(:,:) = sshn(:,:) , i.e. before ⇐= now

change made in r9239

Last edited 7 months ago by nemo (previous) (diff)
Note: See TracTickets for help on using tickets.