Opened 10 months ago

Last modified 6 days ago

#2194 assigned Task

ENHANCE-12_SimonM-Tides

Reported by: smueller Owned by: smueller
Priority: high Milestone: 2019 WP
Component: SBC Version: trunk
Severity: minor Keywords: tides
Cc: Review:
MP ready?:
Progress: Implementation in progress

Description (last modified by smueller)

Summary

Action ENHANCE-12_SimonM-Tides
PI(S) Simon Müller, Nicolas Bruneau
Digest This action aims to enhance the implementation of tidal forcing with the addition of an optional, alternative parameter set for the harmonic expansion of the tide potential, by somewhat simplifying the existing code, and by converting a currently fixed coefficient into a namelist parameter.
Dependencies
Branch NEMO/branches/2019/dev_r10742_ENHANCE-12_SimonM-Tides
Previewer(s) Jérôme Chanut
Reviewer(s) Jérôme Chanut
Wiki 2019WP/ENHANCE-12_SimonM-Tides

Abstract

This action aims to enhance the implementation of tidal forcing with the addition of an optional, alternative parameter set for the harmonic expansion of the tide potential, by somewhat simplifying the existing code, and by converting a currently fixed coefficient into a namelist parameter.

Description

This action aims to enhance the implementation of tidal forcing with the addition of an optional, alternative parameter set for the harmonic expansion of the tide potential and by converting a currently fixed coefficient into a configurable namelist parameter; this work has previously been implemented and tested by Nicolas Bruneau in a pre-4.0beta version of NEMO.

Further, this action aims to reduce the total number of modules related to tides (the current implementation comprises the modules sbctide, tideini, tide_mod, updtide, and bdytide) and to thereby somewhat simplify the current implementation of tidal forcing.

Implementation

See 2019WP/ENHANCE-12_SimonM-Tides

Reference manual and web pages updates

Using part 1 and 2, define the summary of changes to be done in reference manuals (tex files), guide (rst files) and in the content of web pages.

Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks.

Commit History (24)

ChangesetAuthorTimeChangeLog
11664smueller2019-10-08T19:32:15+02:00

Inclusion of selected long-periodic tidal constituents in the computation of the tidal potential (ticket #2194)

10865smueller2019-04-12T11:58:31+02:00

Removal of redundant source code in modules bdydta and bdytides (ticket #2194)

10861smueller2019-04-11T14:45:00+02:00

Suppression of optional complex conjugation of tidal input data at open boundaries (ticket #2194)

10860smueller2019-04-11T11:35:27+02:00

Relocation of the time-of-day computation in subroutine upd_tide (module tide_mod) to its callers (ticket #2194)

10856smueller2019-04-09T17:46:52+02:00

Replacement of the temporary modification of a global variable in subroutine tide_update (module tide_mod) by an alternative, local mechanism (ticket #2194)

10855smueller2019-04-09T13:32:20+02:00

Simplification of subroutine tide_update (module tide_mod) by transferring variable initialisations to other subroutines (ticket #2194)

10852smueller2019-04-08T19:03:04+02:00

Renaming of subroutine sbc_tide of module sbctide to tide_update, transfer of this subroutine to module tide_mod, removal of the emptied module sbctide, and related adjustments (ticket #2194)

10840smueller2019-04-04T19:09:12+02:00

Simplification of initialisation of tidal-constituent parameters (module tide_mod) (ticket #2194)

10839smueller2019-04-04T17:55:33+02:00

Adjustments to enable the use of subroutine tide_init_harmonics for the initialisation of harmonic analysis of a number of tidal constituents that differs from the number of constituents selected for tidal forcing (ticket #2194)

10836smueller2019-04-03T17:43:15+02:00

Correction of the declaration of variable tide_components in subroutine dia_harm_init of module diaharm (ticket #2194)

10830smueller2019-04-03T13:11:17+02:00

Reversion of an error message in subroutine dia_harm_init of module diaharm to the version that was present prior to changeset [10425] (ticket #2194)

10826smueller2019-04-02T17:41:29+02:00

Correction of a variable declaration in subroutine dia_harm_init of module diaharm (ticket #2194)

10822smueller2019-04-01T17:50:07+02:00

Addition of a new type (tide_harmonics in module tide_mod), two replacements of four separate arrays for the storage of oscillation parameters by one array of variables of this new type (in modules diaharm and tide_mod), and related adjustments in various modules (bdytides, diaharm, sbctides, and tide_mod) (ticket #2194)

10811smueller2019-03-29T13:54:25+01:00

Replacement of the module variable used to store information about all available tidal components (variable Wave in module tide_mod) by an array used to store information about the selected components only (variable tide_components in module tide_mod), replacement of the corresponding initialisation subroutine, as well as related adjustments in various modules (bdytides, diaharm, sbctide, and tide_mod) and in one include file (tide.h90) (ticket #2194)

10805smueller2019-03-27T17:23:20+01:00

Relocation of include file tide.h90 to subdirectory src/OCE/TDE (ticket #2194)

10801smueller2019-03-25T20:34:17+01:00

Update of the reference namelist and of two configuration namelists to complement the namelist modification of changeset [10800] (ticket #2194)

10800smueller2019-03-25T18:19:23+01:00

Renaming of two items of namelist nam_tide to bring them in line with the namelist naming convention (ticket #2194)

10793smueller2019-03-21T19:43:33+01:00

Replacement of a hard-coded coefficient by namelist parameter rn_tide_gamma (ticket #2194)

10777smueller2019-03-19T16:39:00+01:00

Removal of module updtide and inclusion of its contents into module tide_mod (ticket #2194)

10773smueller2019-03-18T13:38:52+01:00

Transfer of five public variables, their allocation, and two subroutines from module sbctide to module tide_mod (ticket #2194)

10772smueller2019-03-16T11:17:25+01:00

Removal of module tideini and inclusion of its contents into module tide_mod (ticket #2194)

10752smueller2019-03-14T14:51:09+01:00

Relocation of module tide_mod to subdirectory src/OCE/TDE (ticket #2194)

10749smueller2019-03-13T17:18:14+01:00

Addition of subdirectory src/OCE/TDE for tide-related source code (ticket #2194)

10744smueller2019-03-12T15:10:42+01:00

Inception of the development branch for action ENHANCE-12_SimonM-Tides of the 2019 work plan, see ticket #2194

Change History (35)

comment:1 Changed 10 months ago by smueller

  • Description modified (diff)

comment:2 Changed 10 months ago by smueller

  • Description modified (diff)
  • Summary changed from ENHANCE-08_SimonM-Tides to ENHANCE-12_SimonM-Tides

comment:3 Changed 9 months ago by nemo

  • Priority changed from low to high

comment:4 Changed 9 months ago by smueller

  • Owner set to smueller
  • Status changed from new to assigned

comment:5 Changed 8 months ago by smueller

  • Description modified (diff)
  • Type changed from Task to Bug
  • Version trunk deleted

comment:6 Changed 8 months ago by smueller

  • Type changed from Bug to Task
  • Version set to trunk

comment:7 Changed 8 months ago by smueller

  • Description modified (diff)

comment:8 Changed 7 months ago by smueller

In 10744:

Inception of the development branch for action ENHANCE-12_SimonM-Tides of the 2019 work plan, see ticket #2194

comment:9 Changed 7 months ago by smueller

  • Description modified (diff)

comment:10 Changed 7 months ago by smueller

In 10749:

Addition of subdirectory src/OCE/TDE for tide-related source code (ticket #2194)

comment:11 Changed 7 months ago by smueller

In 10752:

Relocation of module tide_mod to subdirectory src/OCE/TDE (ticket #2194)

comment:12 Changed 7 months ago by smueller

In 10772:

Removal of module tideini and inclusion of its contents into module tide_mod (ticket #2194)

comment:13 Changed 7 months ago by smueller

In 10773:

Transfer of five public variables, their allocation, and two subroutines from module sbctide to module tide_mod (ticket #2194)

comment:14 Changed 7 months ago by smueller

In 10777:

Removal of module updtide and inclusion of its contents into module tide_mod (ticket #2194)

comment:15 Changed 7 months ago by smueller

In 10793:

Replacement of a hard-coded coefficient by namelist parameter rn_tide_gamma (ticket #2194)

comment:16 Changed 7 months ago by smueller

In 10800:

Renaming of two items of namelist nam_tide to bring them in line with the namelist naming convention (ticket #2194)

comment:17 Changed 7 months ago by smueller

In 10801:

Update of the reference namelist and of two configuration namelists to complement the namelist modification of changeset [10800] (ticket #2194)

comment:18 Changed 7 months ago by smueller

In 10805:

Relocation of include file tide.h90 to subdirectory src/OCE/TDE (ticket #2194)

comment:19 Changed 7 months ago by smueller

In 10811:

Replacement of the module variable used to store information about all available tidal components (variable Wave in module tide_mod) by an array used to store information about the selected components only (variable tide_components in module tide_mod), replacement of the corresponding initialisation subroutine, as well as related adjustments in various modules (bdytides, diaharm, sbctide, and tide_mod) and in one include file (tide.h90) (ticket #2194)

comment:20 Changed 7 months ago by smueller

In 10822:

Addition of a new type (tide_harmonics in module tide_mod), two replacements of four separate arrays for the storage of oscillation parameters by one array of variables of this new type (in modules diaharm and tide_mod), and related adjustments in various modules (bdytides, diaharm, sbctides, and tide_mod) (ticket #2194)

comment:21 Changed 6 months ago by smueller

In 10826:

Correction of a variable declaration in subroutine dia_harm_init of module diaharm (ticket #2194)

comment:22 Changed 6 months ago by smueller

In 10830:

Reversion of an error message in subroutine dia_harm_init of module diaharm to the version that was present prior to changeset [10425] (ticket #2194)

comment:23 Changed 6 months ago by smueller

In 10836:

Correction of the declaration of variable tide_components in subroutine dia_harm_init of module diaharm (ticket #2194)

comment:24 Changed 6 months ago by smueller

In 10839:

Adjustments to enable the use of subroutine tide_init_harmonics for the initialisation of harmonic analysis of a number of tidal constituents that differs from the number of constituents selected for tidal forcing (ticket #2194)

comment:25 Changed 6 months ago by smueller

In 10840:

Simplification of initialisation of tidal-constituent parameters (module tide_mod) (ticket #2194)

comment:26 Changed 6 months ago by smueller

In 10852:

Renaming of subroutine sbc_tide of module sbctide to tide_update, transfer of this subroutine to module tide_mod, removal of the emptied module sbctide, and related adjustments (ticket #2194)

comment:27 Changed 6 months ago by smueller

In 10855:

Simplification of subroutine tide_update (module tide_mod) by transferring variable initialisations to other subroutines (ticket #2194)

comment:28 Changed 6 months ago by smueller

In 10856:

Replacement of the temporary modification of a global variable in subroutine tide_update (module tide_mod) by an alternative, local mechanism (ticket #2194)

comment:29 Changed 6 months ago by smueller

In 10860:

Relocation of the time-of-day computation in subroutine upd_tide (module tide_mod) to its callers (ticket #2194)

comment:30 Changed 6 months ago by smueller

In 10861:

Suppression of optional complex conjugation of tidal input data at open boundaries (ticket #2194)

comment:31 Changed 6 months ago by smueller

In 10865:

Removal of redundant source code in modules bdydta and bdytides (ticket #2194)

comment:32 Changed 6 weeks ago by smueller

  • Progress modified (diff)

comment:33 Changed 6 weeks ago by smueller

  • MP ready? set to no

comment:34 Changed 5 weeks ago by smueller

  • MP ready? no deleted

comment:35 Changed 6 days ago by smueller

In 11664:

Inclusion of selected long-periodic tidal constituents in the computation of the tidal potential (ticket #2194)

Note: See TracTickets for help on using tickets.