Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#2232 closed Bug (fixed)

Failure of AMM12 SETTE test

Reported by: jamesharle Owned by: jamesharle
Priority: low Milestone:
Component: DIA Version: release-4.0
Severity: minor Keywords: 25hr_mean,
Cc:

Description

Context

On the ARCHER HPC facility the SETTE test for AMM12 fails with an XIOS "Numeric conversion not representable" from the 25 hour meaning diagnostics

Analysis

It appears that the 25 hour mean vertical velocity array (wn_25h) is initialised from wn (dia_25h_init), before wn has itself been initialised.

Fix

Delay the initialisation of wn_25h until the first call of dia_25h

  • dia25h.F90

     
    9999      sshn_25h(:,:)   = sshb(:,:) 
    100100      un_25h  (:,:,:) = ub  (:,:,:) 
    101101      vn_25h  (:,:,:) = vb  (:,:,:) 
    102       wn_25h  (:,:,:) = wn  (:,:,:) 
    103102      avt_25h (:,:,:) = avt (:,:,:) 
    104103      avm_25h (:,:,:) = avm (:,:,:) 
    105104      IF( ln_zdftke ) THEN 
     
    148147      ! local variable for debugging 
    149148      ll_print = ll_print .AND. lwp 
    150149 
     150      ! wn_25h could not be initialised in dia_25h_init, so we do it here instead 
     151      IF( kt == nn_it000 ) THEN 
     152         wn_25h(:,:,:) = wn(:,:,:) 
     153      ENDIF 
     154 
    151155      ! Sum of 25 hourly instantaneous values to give a 25h mean from 24hours every day 
    152156      IF( MOD( kt, i_steps ) == 0  .AND. kt /= nn_it000 ) THEN 
    153157 
     
    222226         zw3d(:,:,:) = vn_25h(:,:,:)*vmask(:,:,:) + zmdi*(1.0-vmask(:,:,:)) 
    223227         CALL iom_put("vomecrty25h", zw3d  )   ! j-current 
    224228         zw3d(:,:,:) = wn_25h(:,:,:)*wmask(:,:,:) + zmdi*(1.0-tmask(:,:,:)) 
    225          CALL iom_put("vomecrtz25h", zw3d )   ! k-current 
     229         CALL iom_put("vovecrtz25h", zw3d )   ! k-current 
    226230         ! Write vertical physics 
    227231         zw3d(:,:,:) = avt_25h(:,:,:)*wmask(:,:,:) + zmdi*(1.0-tmask(:,:,:)) 
    228232         CALL iom_put("avt25h", zw3d )   ! diffusivity 


Commit History (2)

ChangesetAuthorTimeChangeLog
10644jamesharle2019-02-07T10:27:12+01:00

Update variable name for ticket #2232

10640jamesharle2019-02-06T13:33:10+01:00

Correction for un-initialised variable wn_25h in 25hour meaning diagmostics (see ticket #2232).

Change History (3)

comment:1 Changed 14 months ago by jamesharle

In 10640:

Correction for un-initialised variable wn_25h in 25hour meaning
diagmostics (see ticket #2232).

comment:2 Changed 14 months ago by jamesharle

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 14 months ago by jamesharle

In 10644:

Update variable name for ticket #2232

Note: See TracTickets for help on using tickets.