#2284 closed Bug (fixed)
Bug in NST/agrif_top_update.F90
| Reported by: | acc | Owned by: | jchanut |
|---|---|---|---|
| Priority: | low | Milestone: | Unscheduled |
| Component: | AGRIF | Version: | v4.0 |
| Severity: | minor | Keywords: | v4.0 |
| Cc: |
Description
Context
Whilst doing some branch work where, amongst other changes, we are changing the trb, trn and tra arrays, I noticed this at line 140 in NST/agrif_top_update.F90:
trb(ji,jj,jk,jn) = tsb(ji,jj,jk,jn) &
& + atfp * ( tabres_child(ji,jj,jk,jn) &
& - trn(ji,jj,jk,jn) ) * tmask(ji,jj,jk)
Presumeably that tsb on the RHS should be a trb?
Analysis
The code doesn't seem to be active in any SETTE tests but does exist in the trunk and release-4.0.
...
Fix
Change tsb to trb if confirmed by an AGRIF expert.
Commit History (2)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 11079 | jchanut | 2019-06-05T16:18:10+02:00 | |
| 11078 | jchanut | 2019-06-05T16:17:09+02:00 |
Change History (6)
comment:1 Changed 5 years ago by jchanut
comment:2 Changed 5 years ago by clevy
- Owner changed from systeam to jchanut
- Status changed from new to assigned
comment:3 Changed 5 years ago by jchanut
In 11078:
comment:4 Changed 5 years ago by jchanut
In 11079:
comment:5 Changed 5 years ago by jchanut
- Resolution set to fixed
- Status changed from assigned to closed
comment:6 Changed 2 years ago by nemo
- Keywords v4.0 added
Note: See
TracTickets for help on using
tickets.
I confirm that's an ugly bug.