Opened 8 months ago

Closed 8 months ago

#2346 closed Bug (fixed)

Sign change in lbc call for total depth in split explicit routine

Reported by: jchanut Owned by: systeam
Priority: low Milestone:
Component: DYN Version: trunk
Severity: major Keywords:
Cc:

Description

Context

dynspg_ts module

Analysis

line 688, add sign change in argument of lbc_lnk_multi for hu_e, hv_e, hur_e, hvr_e

            CALL lbc_lnk_multi( 'dynspg_ts', ua_e , 'U', -1._wp, va_e , 'V', -1._wp  &
                 &                         , hu_e , 'U', -1._wp, hv_e , 'V', -1._wp  &
                 &                         , hur_e, 'U', -1._wp, hvr_e, 'V', -1._wp  )

Somehow strange that we haven't seen any effect so far ?

Fix

Should be

            CALL lbc_lnk_multi( 'dynspg_ts', ua_e , 'U', -1._wp, va_e , 'V', -1._wp  &
                 &                         , hu_e , 'U',  1._wp, hv_e , 'V',  1._wp  &
                 &                         , hur_e, 'U',  1._wp, hvr_e, 'V',  1._wp  )

Commit History (2)

ChangesetAuthorTimeChangeLog
12073jchanut2019-12-05T16:11:44+01:00

#2346, correct lbc call for depths

12072jchanut2019-12-05T16:07:50+01:00

#2346, correct lbc call for depths

Change History (4)

comment:1 Changed 8 months ago by jchanut

After closer examination, this bug seems to be harmless since boundary values of hu and hv are not necessary to update "interior" values or barotropic velocities.
The second good news is that it is likely that the call of lbc_lnk for these 4 arrays (at each barotropic iteration) may not be necessary. Hence this could save some mpp communication time. However, there could be a side effect of doing so for open boundaries. To be investigated further.

comment:2 Changed 8 months ago by jchanut

In 12072:

#2346, correct lbc call for depths

comment:3 Changed 8 months ago by jchanut

In 12073:

#2346, correct lbc call for depths

comment:4 Changed 8 months ago by clem

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.